From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 2/6] ARM: bcm476x: Add system timer Date: Mon, 08 Oct 2012 20:43:20 -0600 Message-ID: <50738F48.5010002@wwwdotorg.org> References: <20121007015300.828366635@gmail.com> <20121007015406.470633343@gmail.com> <1822741.oh36baA1m8@flexo> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1822741.oh36baA1m8@flexo> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Florian Fainelli Cc: Domenico Andreoli , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 10/08/2012 05:50 AM, Florian Fainelli wrote: > On Sunday 07 October 2012 03:53:02 Domenico Andreoli wrote: >> From: Domenico Andreoli >> >> System timer implementation for the BCM476x SoCs. >> Index: b/arch/arm/boot/dts/bcm476x.dtsi >> + timer { >> + compatible = "brcm,bcm476x-system-timer"; >> + reg = <0xba000 0x1000>; >> + interrupt-parent = <&vic0>; >> + interrupts = <4>, <11>; >> + clock-frequency = <24000000>; >> + }; > > This should rather be timer: timer@ba0000 for this node to be uniquely named. I only see 1 timer node in this series, so "timer" is already unique, isn't it?