From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 1/6] ARM: bcm476x: Add infrastructure Date: Mon, 08 Oct 2012 20:48:20 -0600 Message-ID: <50739074.8000001@wwwdotorg.org> References: <20121007015300.828366635@gmail.com> <20121007015405.958959522@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20121007015405.958959522-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Domenico Andreoli Cc: Domenico Andreoli , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 10/06/2012 07:53 PM, Domenico Andreoli wrote: > BCM476x's minimal infrastructure, Kernel's great reuse. > Index: b/arch/arm/boot/dts/bcm476x.dtsi > + chosen { > + bootargs = "earlyprintk"; > + }; > Index: b/arch/arm/configs/bcm476x_defconfig > +CONFIG_CMDLINE="root=/dev/mmcblk0p2 ro console=ttyAMA1,115200 rootwait init=/bin/bash" > +CONFIG_CMDLINE_FROM_BOOTLOADER=y I'm not sure you need to specify a default command-line in both those places. I would be inclined to leave out the root= option as well; it's pretty specific to however the user's SD card was partitioned, so there could be quite some variation there I think? Oh, especially since I think you said there was no SD driver yet anyway?