From: kishon <kishon@ti.com>
To: Vivek Gautam <gautam.vivek@samsung.com>
Cc: linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, gregkh@linuxfoundation.org,
stern@rowland.harvard.edu, balbi@ti.com, rob.herring@calxeda.com,
kgene.kim@samsung.com, jg1.han@samsung.com,
thomas.abraham@linaro.org, p.paneri@samsung.com,
yulgon.kim@samsung.com
Subject: Re: [PATCH 2/5] ARM: S3C64XX: Add phy_type to pmu_isolation
Date: Tue, 9 Oct 2012 11:03:55 +0530 [thread overview]
Message-ID: <5073B743.9000200@ti.com> (raw)
In-Reply-To: <1349705548-15207-3-git-send-email-gautam.vivek@samsung.com>
Hi,
On Monday 08 October 2012 07:42 PM, Vivek Gautam wrote:
> It adds 'type' argument to pmu_isolation function, aligning
> with other platforms, which keeps track of usbphy_type.
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> ---
> arch/arm/mach-s3c64xx/setup-usb-phy.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-s3c64xx/setup-usb-phy.c b/arch/arm/mach-s3c64xx/setup-usb-phy.c
> index 3aee778..b7d1d95 100644
> --- a/arch/arm/mach-s3c64xx/setup-usb-phy.c
> +++ b/arch/arm/mach-s3c64xx/setup-usb-phy.c
> @@ -13,7 +13,7 @@
> #include <mach/map.h>
> #include <mach/regs-sys.h>
>
> -void s5p_usb_phy_pmu_isolation(int on)
> +void s5p_usb_phy_pmu_isolation(int on, int type)
IMO, this patch should have been squashed with the previous patch. IIUC,
you have changed the call to this function for taking two arguments in
your previous patch. Wouldn't that introduce compilation break after
applying your first patch?
Thanks
Kishon
next prev parent reply other threads:[~2012-10-09 5:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 14:12 [PATCH 0/5] Adding usb2.0 host-phy support for exynos5250 Vivek Gautam
2012-10-08 14:12 ` [PATCH 1/5] usb: phy: samsung: Add host phy support to samsung-phy driver Vivek Gautam
[not found] ` <1349705548-15207-1-git-send-email-gautam.vivek-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-10-08 14:12 ` [PATCH 2/5] ARM: S3C64XX: Add phy_type to pmu_isolation Vivek Gautam
2012-10-09 5:33 ` kishon [this message]
[not found] ` <5073B743.9000200-l0cyMroinI0@public.gmane.org>
2012-10-09 10:51 ` Vivek Gautam
[not found] ` <CAFp+6iE6Er088dYwp8q7uQuZhw9bdYbJXQDbJp66W6tD7+C-Xw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-09 11:12 ` Jingoo Han
2012-10-09 12:35 ` Vivek Gautam
2012-10-08 14:12 ` [PATCH 3/5] ARM: Exynos5250: Enabling samsung-usbphy driver Vivek Gautam
2012-10-08 14:12 ` [PATCH 4/5] usb: s5p-ehci: Adding phy driver support Vivek Gautam
[not found] ` <1349705548-15207-5-git-send-email-gautam.vivek-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-10-09 9:40 ` Jingoo Han
2012-10-09 12:44 ` Vivek Gautam
2012-10-08 14:12 ` [PATCH 5/5] usb: exynos-ohci: " Vivek Gautam
2012-10-09 9:46 ` Jingoo Han
2012-10-09 12:47 ` Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5073B743.9000200@ti.com \
--to=kishon@ti.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gautam.vivek@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jg1.han@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.paneri@samsung.com \
--cc=rob.herring@calxeda.com \
--cc=stern@rowland.harvard.edu \
--cc=thomas.abraham@linaro.org \
--cc=yulgon.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).