From: Lokesh Vutla <lokeshvutla@ti.com>
To: Benoit Cousson <b-cousson@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
santosh.shilimkar@ti.com, devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH 1/3] ARM: dts: Renaming elpida_ecb240abacn.dtsi as lpddr2_data.dtsi
Date: Thu, 11 Oct 2012 14:01:19 +0530 [thread overview]
Message-ID: <507683D7.1070606@ti.com> (raw)
In-Reply-To: <5076831A.4020701@ti.com>
On Thursday 11 October 2012 01:58 PM, Benoit Cousson wrote:
> On 10/11/2012 08:16 AM, Lokesh Vutla wrote:
>> + devicetree-discuss
>>
>> Hi Benoit,
>>
>> On Wednesday 10 October 2012 08:18 PM, Benoit Cousson wrote:
>>> Hi Lokesh,
>>>
>>> On 10/10/2012 02:05 PM, Lokesh Vutla wrote:
>>>> Renaming elpida_ecb240abacn.dtsi file generic, so that the
>>>> same file can be reused for other parts from different vendors.
>>>
>>> Could you elaborate a little bit?
>>> Are these settings purely reflecting lpddr2 spec timings?
>>
>> The basic idea is to group data for all the lpddr2 devices in a single
>> file instead of creating separate file for each lpddr2 device.
>>
>> Right now the file elpida_ecb240abacn.dtsi contains only data for
>> lpddr2-s4 2G parts from Elpida.
>> I wanted to add data for lpddr2-s4 4G parts from Samsung.
>> So I renamed the file elpida_ecb240abacn.dtsi as lpddr2_data.dtsi.
>>
>> Please let me know if more clarification is needed.
>
> Well, not anymore... as explained in the previous email, you should not
> do that.
> Keep the Elpida file and create another one for the Samsung part.
> Then each board will be able to select the proper one and include only
> the relevant data.
OK, Ill agree with you.
I ll do the changes and post the V2.
Thanks,
Lokesh
>
> Regards,
> Benoit
>
prev parent reply other threads:[~2012-10-11 8:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1349870716-25511-1-git-send-email-lokeshvutla@ti.com>
[not found] ` <1349870716-25511-4-git-send-email-lokeshvutla@ti.com>
[not found] ` <50758DC7.3070408@ti.com>
2012-10-11 6:16 ` [PATCH 3/3] ARM: dts: EMIF and LPDDR2 device tree data for OMAP5 boards Lokesh Vutla
2012-10-11 8:11 ` Benoit Cousson
2012-10-11 8:15 ` Santosh Shilimkar
[not found] ` <1349870716-25511-2-git-send-email-lokeshvutla@ti.com>
[not found] ` <50758AA0.5080307@ti.com>
2012-10-11 6:16 ` [PATCH 1/3] ARM: dts: Renaming elpida_ecb240abacn.dtsi as lpddr2_data.dtsi Lokesh Vutla
2012-10-11 8:28 ` Benoit Cousson
2012-10-11 8:31 ` Lokesh Vutla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507683D7.1070606@ti.com \
--to=lokeshvutla@ti.com \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).