From: Hui Wang <jason77.wang@gmail.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Hui Wang <jason77.wang@gmail.com>,
jiejing.zhang@freescale.com, linux-input@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 RESEND 1/3] Input: egalax_ts: get gpio from devicetree
Date: Thu, 11 Oct 2012 17:23:11 +0800 [thread overview]
Message-ID: <50768FFF.9060702@gmail.com> (raw)
In-Reply-To: <20121011085535.GA31464@S2101-09.ap.freescale.net>
Shawn Guo wrote:
> Add LAKML ...
>
> On Wed, Oct 10, 2012 at 09:30:36AM -0700, Dmitry Torokhov wrote:
>
>> Hi Hui,
>>
>> On Wed, Oct 10, 2012 at 05:12:01PM +0800, Hui Wang wrote:
>>
>>> The irq_to_gpio() is old, most platforms use GENERIC_GPIO framework
>>> and don't support this API anymore.
>>>
>>> The i.MX6q sabrelite platform equips an egalax touchscreen controller,
>>> and this platform already transfered to GENERIC_GPIO framework, to
>>> support this driver, we use a more generic way to get gpio.
>>>
>> Unfortunately this does break the driver for platforms that do still
>> support irq_to_gpio and have not transitioned to device tree (yet?).
>> It looks like the API suffered from premature deletion...
>>
>> I really do not want to add a new platform data structure with only gpio
>> in it, is there a better way to detect if irq_to_gpio() (even if only a
>> stub) is available?
>>
>>
> If CONFIG_ARCH_HAVE_CUSTOM_GPIO_H is not enabled for an architecture,
> the irq_to_gpio() in include/linux/gpio.h will tell unavailability by
> returning -EINVAL. But ARM
>
So far, the only way i can figure out is to add following in the
arch/arm/include/asm/gpio.h
static inline int arm_irq_to_gpio(unsigned int irq)
{
return -EINVAL;
}
#ifndef irq_to_gpio
#define irq_to_gpio arm_irq_to_gpio
#endif
And remove all irq_to_gpio() function definitions in the arch/arm/, if
mach want a specific irq_to_gpio, they can use macro to define their own.
Regards,
Hui.
next prev parent reply other threads:[~2012-10-11 9:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 9:12 [PATCH v4 RESEND 0/3] Input: egalax_ts: parse devicetree to get gpio Hui Wang
2012-10-10 9:12 ` [PATCH v4 RESEND 1/3] Input: egalax_ts: get gpio from devicetree Hui Wang
2012-10-10 9:12 ` [PATCH v4 RESEND 2/3] Input: add devicetree binding note for Hui Wang
2012-10-10 9:12 ` [PATCH v4 RESEND 3/3] ARM: dts: imx6q-sabrelite: add eeti egalax Hui Wang
2012-10-10 16:30 ` [PATCH v4 RESEND 1/3] Input: egalax_ts: get gpio from devicetree Dmitry Torokhov
2012-10-11 8:55 ` Shawn Guo
2012-10-11 9:23 ` Hui Wang [this message]
2012-10-11 10:19 ` Russell King - ARM Linux
2012-10-11 10:25 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50768FFF.9060702@gmail.com \
--to=jason77.wang@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jiejing.zhang@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).