From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bo Shen Subject: Re: [PATCH] i2c: i2c-gpio: fix issue when DT node greater than 1 Date: Mon, 15 Oct 2012 10:59:19 +0800 Message-ID: <507B7C07.3070702@atmel.com> References: <1347958949-5598-1-git-send-email-voice.shen@atmel.com> <50588A8F.30203@wwwdotorg.org> <50591C9C.2080809@atmel.com> <5059E484.6090708@wwwdotorg.org> <20120919175433.3841a954@endymion.delvare> <5074E349.30605@atmel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5074E349.30605-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jean Delvare Cc: Stephen Warren , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, hskinnemoen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Jean Delvare, On 10/10/2012 10:54, Bo Shen wrote: > > Hi Jean Delvare, > > On 9/19/2012 23:54, Jean Delvare wrote: >> On Wed, 19 Sep 2012 09:28:04 -0600, Stephen Warren wrote: >>> On 09/18/2012 07:15 PM, Bo Shen wrote: >>>> I add the debug info, and it give the following error without this >>>> patch. >>>> >>>> --<8---------------------------------- >>>> adap->name = i2c-gpio-1 >>>> i2c-gpio i2c.2: using pins 30 (SDA) and 31 (SCL) >>>> adap->name = i2c-gpio-1 >>>> i2c-gpio: probe of i2c.3 failed with error -16 >>>> -->8---------------------------------- >>>> >>>> With this patch, it successfully registered. >>>> --<8---------------------------------- >>>> adap->name = i2c-gpio0 >>>> i2c-gpio i2c.2: using pins 30 (SDA) and 31 (SCL) >>>> adap->name = i2c-gpio1 >>>> i2c-gpio i2c.3: using pins 90 (SDA) and 91 (SCL) >>>> -->8---------------------------------- >>> >>> Yes, that explains why the registration fails, but not why this patch is >>> the correct solution to the problem. >>> >>> The problematic code appears to be: >>> >>> snprintf(adap->name, sizeof(adap->name), "i2c-gpio%d", pdev->id); >>> >>> Instead, I think that should be something more like: >>> >>> adap->name = dev_name(&pdev->dev); >> >> strlcpy(adap->name, dev_name(&pdev->dev), sizeof(adap->name)) >> if anything, as adap->name is a buffer, not a pointer. > > I am sorry for late. I have tested with DT, it works. > > Please send this patch to fix the issue. > Thanks. Ping? Will you send this patch? Or, I send this patch and add your S.O.B, which do you prefer? BRs, Bo Shen >> >>> or perhaps: >>> >>> if (pdev->dev.of_node) >>> /* named will be based on DT node name */ >>> adap->name = dev_name(&pdev->dev); >>> else >>> snprintf(adap->name, sizeof(adap->name), "i2c-gpio%d", pdev->id); >>> >>> ? >> >