Re: [PATCH 4/4] ARM: dts: allwinner: Replace status "failed" with "fail"

Jernej Škrabec
2025-12-25T18:49:34Z

Dne četrtek, 25. december 2025 ob 11:36:15 Srednjeevropski standardni čas je Chen-Yu Tsai napisal(a):
> The device tree bindings specify using "fail", not "failed".
>
> Fix up all the ones that are wrong.

While patch indeed fixes the issue, I wonder if "fail" is proper value?
According to specs, it means that device needs repair. What about just
keep "disabled"?

Best regards,
Jernej

>
> Signed-off-by: Chen-Yu Tsai <wens@kernel.org>
> ---
> arch/arm/boot/dts/allwinner/sun4i-a10-dserve-dsrv9703c.dts | 2 +-
> arch/arm/boot/dts/allwinner/sun4i-a10-pov-protab2-ips9.dts | 2 +-
> arch/arm/boot/dts/allwinner/sun6i-a31-hummingbird.dts | 2 +-
> arch/arm/boot/dts/allwinner/sun6i-a31s-primo81.dts | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/allwinner/sun4i-a10-dserve-dsrv9703c.dts b/arch/arm/boot/dts/allwinner/sun4i-a10-dserve-dsrv9703c.dts
> index 63e77c05bfda..f2413ba6a858 100644
> --- a/arch/arm/boot/dts/allwinner/sun4i-a10-dserve-dsrv9703c.dts
> +++ b/arch/arm/boot/dts/allwinner/sun4i-a10-dserve-dsrv9703c.dts
> @@ -112,7 +112,7 @@ axp209: pmic@34 {
>
> &i2c1 {
> /* pull-ups and devices require AXP209 LDO3 */
> - status = "failed";
> + status = "fail";
> };
>
> &i2c2 {
> diff --git a/arch/arm/boot/dts/allwinner/sun4i-a10-pov-protab2-ips9.dts b/arch/arm/boot/dts/allwinner/sun4i-a10-pov-protab2-ips9.dts
> index c32596947647..e0c7099015da 100644
> --- a/arch/arm/boot/dts/allwinner/sun4i-a10-pov-protab2-ips9.dts
> +++ b/arch/arm/boot/dts/allwinner/sun4i-a10-pov-protab2-ips9.dts
> @@ -96,7 +96,7 @@ axp209: pmic@34 {
>
> &i2c1 {
> /* pull-ups and devices require AXP209 LDO3 */
> - status = "failed";
> + status = "fail";
> };
>
> &i2c2 {
> diff --git a/arch/arm/boot/dts/allwinner/sun6i-a31-hummingbird.dts b/arch/arm/boot/dts/allwinner/sun6i-a31-hummingbird.dts
> index 5bce7a32651e..5dfd36e3a49d 100644
> --- a/arch/arm/boot/dts/allwinner/sun6i-a31-hummingbird.dts
> +++ b/arch/arm/boot/dts/allwinner/sun6i-a31-hummingbird.dts
> @@ -170,7 +170,7 @@ hdmi_out_con: endpoint {
>
> &i2c0 {
> /* pull-ups and devices require AXP221 DLDO3 */
> - status = "failed";
> + status = "fail";
> };
>
> &i2c1 {
> diff --git a/arch/arm/boot/dts/allwinner/sun6i-a31s-primo81.dts b/arch/arm/boot/dts/allwinner/sun6i-a31s-primo81.dts
> index b32b70ada7fd..fefd887fbc39 100644
> --- a/arch/arm/boot/dts/allwinner/sun6i-a31s-primo81.dts
> +++ b/arch/arm/boot/dts/allwinner/sun6i-a31s-primo81.dts
> @@ -90,7 +90,7 @@ hdmi_out_con: endpoint {
>
> &i2c0 {
> /* pull-ups and device VDDIO use AXP221 DLDO3 */
> - status = "failed";
> + status = "fail";
> };
>
> &i2c1 {
>