From: Kukjin Kim <kgene.kim@samsung.com>
To: Arun Kumar K <arunkk.samsung@gmail.com>
Cc: sw0312.kim@samsung.com, Arun Kumar K <arun.kk@samsung.com>,
linux-samsung-soc@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, kgene.kim@samsung.com,
k.debski@samsung.com, jtp.park@samsung.com,
thomas.abraham@linaro.org, k.lewandowsk@samsung.com,
s.nawrocki@samsung.com, ch.naveen@samsung.com, joshi@samsung.com
Subject: Re: [PATCH v5] ARM: EXYNOS: Add MFC device tree support
Date: Fri, 19 Oct 2012 10:39:25 +0900 [thread overview]
Message-ID: <5080AF4D.4070402@samsung.com> (raw)
In-Reply-To: <CALt3h79k5XsAGM21oOOy0jDh47N8is7LF-bAGcH-PtjK6ekhUw@mail.gmail.com>
On 10/23/12 19:12, Arun Kumar K wrote:
> Hi Seungwoo Kim,
>
> Thank you for the review.
>
>>> +
>>> + /* Reserve memory for MFC only if it's available */
>>> + mfc_mem.compatible = "samsung,mfc-v6";
>>> + if (of_scan_flat_dt(s5p_fdt_find_mfc_mem,&mfc_mem))
>>
>> of_scan_flat_dt() is called but it does not have __init on its
>> definition. So this causes section mismatch.
>>
>
> The function of_scan_flat_dt is having __init in its definition.
Yes.
> I hope you meant the function s5p_fdt_find_mfc_mem which is not
> defined with __init and causing section mismatch.
I think so.
> I will correct this and post an updated patch.
I fixed when I applied.
Seung-Woo, thanks for your reporting.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2012-10-19 1:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 17:09 [PATCH v5] Add MFC device tree support Arun Kumar K
2012-09-27 17:09 ` [PATCH v5] ARM: EXYNOS: " Arun Kumar K
2012-10-12 6:42 ` Arun Kumar K
2012-10-23 7:04 ` 김승우
2012-10-23 10:12 ` Arun Kumar K
2012-10-19 1:39 ` Kukjin Kim [this message]
2012-10-23 14:30 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5080AF4D.4070402@samsung.com \
--to=kgene.kim@samsung.com \
--cc=arun.kk@samsung.com \
--cc=arunkk.samsung@gmail.com \
--cc=ch.naveen@samsung.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=joshi@samsung.com \
--cc=jtp.park@samsung.com \
--cc=k.debski@samsung.com \
--cc=k.lewandowsk@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sw0312.kim@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).