From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v4 1/3] dt-bindings: net: renesas: Document Renesas Ethernet Switch
Date: Thu, 20 Oct 2022 08:30:28 -0400 [thread overview]
Message-ID: <5081381c-093c-5a2b-6e17-47733a3b12e7@linaro.org> (raw)
In-Reply-To: <TYBPR01MB53418699D3420682CB8B3F31D82A9@TYBPR01MB5341.jpnprd01.prod.outlook.com>
On 19/10/2022 21:31, Yoshihiro Shimoda wrote:
> Hi Krzysztof,
>
>> From: Krzysztof Kozlowski, Sent: Wednesday, October 19, 2022 9:38 PM
>>
>> On 19/10/2022 04:35, Yoshihiro Shimoda wrote:
>>> Document Renesas Etherent Switch for R-Car S4-8 (r8a779f0).
>>>
>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>
>> Thank you for your patch. There is something to discuss/improve.
>
> Thank you for your review!
>
>>> + ethernet-ports:
>>> + type: object
>>> + additionalProperties: false
>>> +
>>> + properties:
>>> + '#address-cells':
>>> + description: Port number of ETHA (TSNA).
>>> + const: 1
>>> +
>>> + '#size-cells':
>>> + const: 0
>>> +
>>> + patternProperties:
>>> + "^port@[0-9a-f]+$":
>>> + type: object
>>> + $ref: /schemas/net/ethernet-controller.yaml#
>>> + unevaluatedProperties: false
>>> +
>>> + properties:
>>> + reg:
>>> + description:
>>> + Port number of ETHA (TSNA).
>>> +
>>> + phy-handle: true
>>> +
>>> + phy-mode: true
>>
>> Why do you need these two properties here? They are provided by
>> ethernet-controller, so I suggest to drop them.
>>
>> I already commented about it in v3.
>
> I'm sorry. I misunderstood you comments. I thought I should drop
> "description" on these properties and "enum" on the phy-mode.
> I'll drop them on v5.
If the enum on phy-mode is different than what ethernet-controller.yaml
brings, then please keep it.
Just remove everything which is already provided by
ethernet-controller.yaml (and does not differ).
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-20 12:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 8:35 [PATCH v4 0/3] net: ethernet: renesas: Add Ethernet Switch driver Yoshihiro Shimoda
2022-10-19 8:35 ` [PATCH v4 1/3] dt-bindings: net: renesas: Document Renesas Ethernet Switch Yoshihiro Shimoda
2022-10-19 12:37 ` Krzysztof Kozlowski
2022-10-20 1:31 ` Yoshihiro Shimoda
2022-10-20 12:30 ` Krzysztof Kozlowski [this message]
2022-10-19 8:35 ` [PATCH v4 2/3] net: ethernet: renesas: Add Ethernet Switch driver Yoshihiro Shimoda
2022-10-19 10:28 ` kernel test robot
2022-10-24 15:27 ` Geert Uytterhoeven
2022-10-24 19:55 ` Arnd Bergmann
2022-10-24 20:35 ` Geert Uytterhoeven
2022-10-24 20:47 ` Arnd Bergmann
2022-10-25 4:39 ` Yoshihiro Shimoda
2022-10-25 6:48 ` Geert Uytterhoeven
2022-10-25 11:24 ` Yoshihiro Shimoda
2022-10-20 2:23 ` Florian Fainelli
2022-10-20 7:35 ` Yoshihiro Shimoda
2022-10-20 14:11 ` Andrew Lunn
2022-10-24 23:04 ` Florian Fainelli
2022-10-20 20:26 ` kernel test robot
2022-10-19 8:35 ` [PATCH v4 3/3] net: ethernet: renesas: rswitch: Add R-Car Gen4 gPTP support Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5081381c-093c-5a2b-6e17-47733a3b12e7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).