From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F4A7C433FE for ; Thu, 20 Oct 2022 12:30:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229988AbiJTMai (ORCPT ); Thu, 20 Oct 2022 08:30:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229874AbiJTMag (ORCPT ); Thu, 20 Oct 2022 08:30:36 -0400 Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77E5017A025 for ; Thu, 20 Oct 2022 05:30:33 -0700 (PDT) Received: by mail-qt1-x832.google.com with SMTP id f22so13546016qto.3 for ; Thu, 20 Oct 2022 05:30:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nwFzTfmaI4aoP9ub3l+xxk91QEvLlkdEzVB8aFhbF8M=; b=GOpQigYwwWrtTc0MsrR0sgADT2xbbze/Spvqf1mCIvK0nTB7VqU254sOkVyTgaaQ6g XnOfwJpzvufp/3VqiIohSnhyU1v1U7x3IHjbJ5uz4AnMU3Mmu0L1zvLILTti72/xnzyP H976nafkHoX6i9s2HduXhGKo6FM9XrbP69tgduk9JzsZcXKnVk4lRh/teVGhxTYG/fxb XOIfr8v8vR4B4/b8b7kII0MK/IVJqEFQUbJ1SIB5ZFqUQ7HysEw7/+ZDRa7CmFm9N+4J 3BEz5sHxO6CyS94uCwcponIV8DyZhZN3STu7lStGisyoQRS5LSVSGXDkcvdFwEmLUk+u Q1og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nwFzTfmaI4aoP9ub3l+xxk91QEvLlkdEzVB8aFhbF8M=; b=i+BTIz2Sgpkhou0ISh3LsaFO6ZQeRhKtbSB+emuFELbR9b9Le+j4Nja8bkJSLA9Qn4 dQfE8X8F0FztwN5PTF+f5q/P5qW6USXq3yGBm8JFSz/mWr2iP8V8sEOzXLC9sMobhhwD U4WtVkrKNtXWLQ9gpWlFDF4yZzrfHIBmqgE/cMcosifeDLG9oDliyRGkLSssbyY9VUWr 2EhwbjzgugxAo0KuaXeuaAsOVp4yt2ikg5tqMBjTTnUo36rW3pZpVQNunbHZiVkpbsba k7hnzuEbXUJfw/SZVS9RZrdIXWYT64reu6j+vD/DLMuYfdYxISV17XQIcAex4xprUWS5 hLGQ== X-Gm-Message-State: ACrzQf2TLZwH1Q/Ap7MoBMDHNaLdFerWF/fX6GzhxTz0dVGStITdU14A HrsyT7J4rIxR9tS4lKaKwR2dMw== X-Google-Smtp-Source: AMsMyM5F9WV0Thpuu3h2+g2DvPdwv/u/qD/2u0zviGnfaQQrCmaqtd0WBCOF7oX5IGMKR+rIqDSxOQ== X-Received: by 2002:a05:622a:214:b0:39c:de63:2580 with SMTP id b20-20020a05622a021400b0039cde632580mr10656012qtx.31.1666269032574; Thu, 20 Oct 2022 05:30:32 -0700 (PDT) Received: from [192.168.10.124] (pool-72-83-177-149.washdc.east.verizon.net. [72.83.177.149]) by smtp.gmail.com with ESMTPSA id s7-20020a05620a254700b006af0ce13499sm7259659qko.115.2022.10.20.05.30.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Oct 2022 05:30:31 -0700 (PDT) Message-ID: <5081381c-093c-5a2b-6e17-47733a3b12e7@linaro.org> Date: Thu, 20 Oct 2022 08:30:28 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v4 1/3] dt-bindings: net: renesas: Document Renesas Ethernet Switch Content-Language: en-US To: Yoshihiro Shimoda , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" Cc: "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" References: <20221019083518.933070-1-yoshihiro.shimoda.uh@renesas.com> <20221019083518.933070-2-yoshihiro.shimoda.uh@renesas.com> <11d6f585-bd9f-246f-29e0-719f0551e6c9@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/10/2022 21:31, Yoshihiro Shimoda wrote: > Hi Krzysztof, > >> From: Krzysztof Kozlowski, Sent: Wednesday, October 19, 2022 9:38 PM >> >> On 19/10/2022 04:35, Yoshihiro Shimoda wrote: >>> Document Renesas Etherent Switch for R-Car S4-8 (r8a779f0). >>> >>> Signed-off-by: Yoshihiro Shimoda >> >> Thank you for your patch. There is something to discuss/improve. > > Thank you for your review! > >>> + ethernet-ports: >>> + type: object >>> + additionalProperties: false >>> + >>> + properties: >>> + '#address-cells': >>> + description: Port number of ETHA (TSNA). >>> + const: 1 >>> + >>> + '#size-cells': >>> + const: 0 >>> + >>> + patternProperties: >>> + "^port@[0-9a-f]+$": >>> + type: object >>> + $ref: /schemas/net/ethernet-controller.yaml# >>> + unevaluatedProperties: false >>> + >>> + properties: >>> + reg: >>> + description: >>> + Port number of ETHA (TSNA). >>> + >>> + phy-handle: true >>> + >>> + phy-mode: true >> >> Why do you need these two properties here? They are provided by >> ethernet-controller, so I suggest to drop them. >> >> I already commented about it in v3. > > I'm sorry. I misunderstood you comments. I thought I should drop > "description" on these properties and "enum" on the phy-mode. > I'll drop them on v5. If the enum on phy-mode is different than what ethernet-controller.yaml brings, then please keep it. Just remove everything which is already provided by ethernet-controller.yaml (and does not differ). > Best regards, Krzysztof