Devicetree
 help / color / mirror / Atom feed
From: Nihal Kumar Gupta <nihal.gupta@oss.qualcomm.com>
To: sashiko-reviews@lists.linux.dev
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
	media-ci@linuxtv.org
Subject: Re: [PATCH v3 2/2] media: qcom: camss: Add Glymur-specific resources
Date: Fri, 20 Nov 2026 10:40:11 +0530	[thread overview]
Message-ID: <5083f607-afb9-4eb0-95d1-38cbf51ba5da@oss.qualcomm.com> (raw)
In-Reply-To: <sashiko-outbox-223366@kernel.org>



On 19-11-2026 20:50, sashiko-bot@kernel.org wrote:
> Can probing qcom,glymur-camss trigger a NULL pointer dereference in
> msm_csiphy_subdev_init_legacy() when no CSI2 PHY remote-endpoint is
> connected in Device Tree?
> 
No, Glymur follows CSIPHY standalone path. So, It won't cause this issue.

> csiphy_res_glymur leaves .csiphy.hw_ops NULL.  In camss_init_subdevices(),
> camss_detect_legacy_phy() defaults camss->legacy_phy to true and only sets
> it to false if it finds an endpoint with a remote port parent named "phy":
> 
> drivers/media/platform/qcom/camss/camss.c:camss_detect_legacy_phy() {
> 	camss->legacy_phy = true;
> 
> 	/* Find first remote-endpoint and determine if its a PHY */
> 	for_each_endpoint_of_node(camss->dev->of_node, ep) {
> 		remote = of_graph_get_remote_port_parent(ep);
> 		if (!remote)
> 			continue;
> 
> 		camss->legacy_phy = !of_node_name_eq(remote, "phy");
> 		of_node_put(remote);
> 		of_node_put(ep);
> 		break;
> 	}
> }
> 
> Because endpoints under ports are optional (for example when using only
> the internal TPGs or before board endpoints are wired up),
> camss->legacy_phy remains true when none are present.
> camss_init_subdevices() then calls msm_csiphy_subdev_init_legacy(), which
> unconditionally calls csiphy->res->hw_ops->init(csiphy).

-- 
Regards,
Nihal Kumar Gupta


  reply	other threads:[~2026-11-20  5:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 15:04 [PATCH v3 0/2] media: qcom: camss: Fix Glymur CSIPHY topology Nihal Kumar Gupta
2026-11-19 15:04 ` [PATCH v3 1/2] dt-bindings: media: qcom,glymur-camss: Use linear CSI ports Nihal Kumar Gupta
2026-11-22 17:06   ` Krzysztof Kozlowski
2026-11-19 15:04 ` [PATCH v3 2/2] media: qcom: camss: Add Glymur-specific resources Nihal Kumar Gupta
2026-11-19 15:20   ` sashiko-bot
2026-11-20  5:10     ` Nihal Kumar Gupta [this message]
2026-11-20  8:30   ` Loic Poulain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5083f607-afb9-4eb0-95d1-38cbf51ba5da@oss.qualcomm.com \
    --to=nihal.gupta@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=media-ci@linuxtv.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox