devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mitch Bradley <wmb@firmworks.com>
To: Jon Hunter <jon-hunter@ti.com>
Cc: Sebastien Guiriec <s-guiriec@ti.com>,
	devicetree-discuss@lists.ozlabs.org,
	linux-kernel@vger.kernel.org,
	Santosh Shilimkar <santosh.shilimkar@ti.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] ARM: dts: omap5: Update GPIO with address space and interrupts
Date: Tue, 23 Oct 2012 06:55:30 -1000	[thread overview]
Message-ID: <5086CC02.6070801@firmworks.com> (raw)
In-Reply-To: <5086AE8E.60106@ti.com>

On 10/23/2012 4:49 AM, Jon Hunter wrote:

> Therefore, I believe it will improve search time and hence, boot time if
> we have interrupt-parent defined in each node.

I strongly suspect (based on many years of performance tuning, with
special focus on boot time) that the time difference will be completely
insignificant.  The total extra time for walking up the interrupt tree
for every interrupt in a large system is comparable to the time it takes
to send a few characters out a UART.  So you can get more improvement
from eliminating a single printk() than from globally adding per-node
interrupt-parent.

Furthermore, the cost of processing all of the interrupt-parent
properties is probably similar to the cost of the avoided tree walks.

CPU cycles are very fast compared to I/O register accesses, say a factor
of 100.  Now consider that many modern devices contain embedded
microcontrollers (SD cards, network interface modules, USB hubs and
devices, ...), and those devices usually require various delays measured
in milliseconds, to ensure that the microcontroller is ready for the
next initialization step.  Those delays are extremely long compared to
CPU cycles.  Obviously, some of that can be overlapped by careful
multithreading, but that isn't free either.

The bottom line is that I'm pretty sure that adding per-node
interrupt-parent would not be worthwhile from the standpoint of speeding
up boot time.

  parent reply	other threads:[~2012-10-23 16:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-23  8:37 [PATCH v2 0/4] ARM: dts: Update OMAP5 with address space and interrupts Sebastien Guiriec
2012-10-23  8:37 ` [PATCH v2 1/4] ARM: dts: omap5: Update GPIO " Sebastien Guiriec
2012-10-23 14:49   ` Jon Hunter
2012-10-23 15:09     ` Benoit Cousson
2012-10-23 15:59       ` Jon Hunter
2012-10-23 16:07         ` Benoit Cousson
2012-10-23 16:15           ` Sebastien Guiriec
2012-10-24  7:44             ` Benoit Cousson
2012-10-23 16:55     ` Mitch Bradley [this message]
     [not found]       ` <5086CC02.6070801-D5eQfiDGL7eakBO8gow8eQ@public.gmane.org>
2012-10-23 23:15         ` Jon Hunter
2012-10-24  0:18           ` Mitch Bradley
2012-10-23  8:37 ` [PATCH v2 2/4] ARM: dts: omap5: Update I2C " Sebastien Guiriec
2012-10-23  8:37 ` [PATCH v2 3/4] ARM: dts: omap5: Update UART " Sebastien Guiriec
2012-10-23  8:37 ` [PATCH v2 4/4] ARM: dts: omap5: Update MMC " Sebastien Guiriec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5086CC02.6070801@firmworks.com \
    --to=wmb@firmworks.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=jon-hunter@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=s-guiriec@ti.com \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).