From: Rob Herring <robherring2@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: grant.likely@secretlab.ca, spear-devel@list.st.com,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, andriy.shevchenko@intel.com
Subject: Re: [PATCH] dt: add helper function to read u8 & u16 variables & arrays
Date: Thu, 25 Oct 2012 08:19:01 -0500 [thread overview]
Message-ID: <50893C45.7010109@gmail.com> (raw)
In-Reply-To: <CAKohpom42SCMJ+=TdvAjqT0ibRugJi_gXkLy+49N6ExcRZqxLQ@mail.gmail.com>
On 10/25/2012 02:03 AM, Viresh Kumar wrote:
> On 12 October 2012 23:31, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>> This adds following helper routines:
>> - of_property_read_u8_array()
>> - of_property_read_u16_array()
>> - of_property_read_u8()
>> - of_property_read_u16()
>>
>> First two actually share most of the code with of_property_read_u32_array(), so
>> the common part is taken out into a macro, which can be used by all three
>> *_array() routines.
>
> Hi Rob,
>
> Any comment here?
For some reason, this does not show up on the list either in my mail or
mail list archives, but it is in patchwork. Can you resend it please.
The main question I have is be32_to_cpup() the right thing to do. I
would expect byte arrays to not need endian conversion, but I haven't
looked at how '/bits/ x' data is stored.
Rob
next prev parent reply other threads:[~2012-10-25 13:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 18:01 [PATCH] dt: add helper function to read u8 & u16 variables & arrays Viresh Kumar
2012-10-15 7:56 ` Shevchenko, Andriy
2012-10-15 8:06 ` Viresh Kumar
2012-10-25 7:03 ` Viresh Kumar
2012-10-25 13:19 ` Rob Herring [this message]
2012-10-25 14:18 ` Viresh Kumar
2012-10-26 4:17 ` Viresh Kumar
-- strict thread matches above, loose matches on Subject: below --
2012-11-20 4:45 Viresh Kumar
2012-11-20 8:21 ` Shevchenko, Andriy
2012-11-20 8:25 ` Viresh Kumar
2012-11-20 17:21 ` Stephen Warren
[not found] ` <0ee5b74534a09d75c14b22c2d9330c4971ab30fb.1353386646.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-11-21 4:24 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50893C45.7010109@gmail.com \
--to=robherring2@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=spear-devel@list.st.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).