From: Afzal Mohammed <x0148406-l0cyMroinI0@public.gmane.org>
To: Daniel Mack <zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Kevin Hilman <khilman-l0cyMroinI0@public.gmane.org>,
Alessandro Zummo
<a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>,
davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
Rob Landley <rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v4 3/5] rtc: omap: dt support
Date: Mon, 29 Oct 2012 13:33:35 +0530 [thread overview]
Message-ID: <508E3857.6080109@ti.com> (raw)
In-Reply-To: <5084523F.2070800-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hi Daniel,
On Monday 22 October 2012 01:21 AM, Daniel Mack wrote:
> On 19.10.2012 11:59, Afzal Mohammed wrote:
>> +static const struct of_device_id omap_rtc_of_match[] = {
>> + { .compatible = "ti,da830-rtc",
>> + .data =&omap_rtc_devtype[OMAP_RTC_DATA_DA830_IDX],
> Wouldn't it make sense to list all the compatible models here? The
> advantage of a compatible list is that we can name the models
> explicitly, or maybe at least "davinci-rtc". Is there any reason for
> this particular name?
Exact name followed by compatible models needs to be
specified in DT node only, right ? (when driver for the
first variant can handle it)
And when additional features of newer IP's has to be
leveraged, new entries can be added in the driver
match table.
First known variant of SoC for DT is da830 (exact name),
hence it was used.
Regards
Afzal
next prev parent reply other threads:[~2012-10-29 8:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 9:59 [PATCH v4 0/5] rtc: omap dt support (for am33xx) Afzal Mohammed
2012-10-19 9:59 ` [PATCH v4 1/5] rtc: omap: kicker mechanism support Afzal Mohammed
[not found] ` <cover.1350633036.git.afzal-l0cyMroinI0@public.gmane.org>
2012-10-19 9:59 ` [PATCH v4 2/5] ARM: davinci: remove rtc kicker release Afzal Mohammed
2012-10-19 9:59 ` [PATCH v4 3/5] rtc: omap: dt support Afzal Mohammed
2012-10-21 19:51 ` Daniel Mack
[not found] ` <5084523F.2070800-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-29 8:03 ` Afzal Mohammed [this message]
2012-10-19 9:59 ` [PATCH v4 4/5] rtc: omap: depend on am33xx Afzal Mohammed
2012-10-19 9:59 ` [PATCH v4 5/5] rtc: omap: Add runtime pm support Afzal Mohammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508E3857.6080109@ti.com \
--to=x0148406-l0cymroini0@public.gmane.org \
--cc=a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=khilman-l0cyMroinI0@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).