Re: [PATCH next v10 2/2] dt-bindings: i2c: add entry for hisilicon,ascend910-i2c

[Yicong Yang <yangyicong@huawei.com>]

On 2022/11/1 16:07, Weilong Chen wrote:
> Add the new compatible for HiSilicon i2c.
> 

Reviewed-by: Yicong Yang <yangyicong@hisilicon.com>

> Signed-off-by: Weilong Chen <chenweilong@huawei.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> Change since v9:
> - No change
> Link: https://lore.kernel.org/lkml/20221029115937.179788-2-chenweilong@huawei.com/
> 
> Change since v8:
> - Use vendor,soc-ipblock format.
> - Drop quotes.
> - Drop "Device Tree bindings".
> - Description goes to top level description.
> - Use defines for constants.
> Link: https://lore.kernel.org/lkml/20221024015151.342651-2-chenweilong@huawei.com/
> 
>  .../bindings/i2c/hisilicon,ascend910-i2c.yaml | 73 +++++++++++++++++++
>  MAINTAINERS                                   |  1 +
>  2 files changed, 74 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml
> 
> diff --git a/Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml b/Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml
> new file mode 100644
> index 000000000000..7d7a8de7bcd8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/hisilicon,ascend910-i2c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HiSilicon common I2C controller
> +
> +maintainers:
> +  - Yicong Yang <yangyicong@hisilicon.com>
> +
> +description:
> +  The HiSilicon common I2C controller can be used for many different
> +  types of SoC such as Huawei Ascend AI series chips.
> +
> +allOf:
> +  - $ref: /schemas/i2c/i2c-controller.yaml#
> +
> +properties:
> +  compatible:
> +    const: hisilicon,ascend910-i2c
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-frequency:
> +    default: 400000
> +
> +  i2c-sda-falling-time-ns:
> +    default: 343
> +
> +  i2c-scl-falling-time-ns:
> +    default: 203
> +
> +  i2c-sda-hold-time-ns:
> +    default: 830
> +
> +  i2c-scl-rising-time-ns:
> +    default: 365
> +
> +  i2c-digital-filter-width-ns:
> +    default: 0
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    i2c@38b0000 {
> +      compatible = "hisilicon,ascend910-i2c";
> +      reg = <0x38b0000 0x10000>;
> +      interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
> +      i2c-sda-falling-time-ns = <56>;
> +      i2c-scl-falling-time-ns = <56>;
> +      i2c-sda-hold-time-ns = <56>;
> +      i2c-scl-rising-time-ns = <56>;
> +      i2c-digital-filter;
> +      i2c-digital-filter-width-ns = <0x0>;
> +      clocks = <&alg_clk>;
> +      clock-frequency = <400000>;
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d1214d83c2df..d42e34d1e8e2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -9228,6 +9228,7 @@ M:	Yicong Yang <yangyicong@hisilicon.com>
>  L:	linux-i2c@vger.kernel.org
>  S:	Maintained
>  W:	https://www.hisilicon.com
> +F:	Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml
>  F:	drivers/i2c/busses/i2c-hisi.c
>  
>  HISILICON LPC BUS DRIVER
>