[PATCH V2 0/3] ARM: dts: omap5: EMIF and LPDDR2 device tree data

[PATCH V2 0/3] ARM: dts: omap5: EMIF and LPDDR2 device tree data

[Lokesh Vutla]

This patch series adds Device tree data for the EMIF 
sdram controllers in OMAP5 and LPDDR2 memory devices 
in OMAP5-evm board.

Testing:
- Boot tested on OMAP5430 evm.
- Built EMIF as a module.

Changes from v1:
* Created a seperate dtsi file for Samsung LPDDR2 memory device 
  used in OMAP5-evm.
* Passing reg and interrupt fields from dt for EMIF1 and EMIF2.

Lokesh Vutla (3):
  ARM: dts: omap5-evm: Fix size of memory defined for EVM
  ARM: dts: omap5: EMIF device tree data for OMAP5 boards
  ARM: dts: omap5-evm: LPDDR2 memory device details for EVM

 arch/arm/boot/dts/omap5-evm.dts           |   13 +++++-
 arch/arm/boot/dts/omap5.dtsi              |   24 +++++++++++
 arch/arm/boot/dts/samsung_k3pe0e000b.dtsi |   67 +++++++++++++++++++++++++++++
 3 files changed, 103 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/boot/dts/samsung_k3pe0e000b.dtsi

-- 
1.7.10.4

[PATCH V2 1/3] ARM: dts: omap5-evm: Fix size of memory defined for EVM

[Lokesh Vutla]

Memory present for OMAP5-evm is 2GB. But in dts file
it is specified as 1GB. Correcting the same.

Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
 arch/arm/boot/dts/omap5-evm.dts |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/omap5-evm.dts b/arch/arm/boot/dts/omap5-evm.dts
index 9c41a3f..6f87e1a 100644
--- a/arch/arm/boot/dts/omap5-evm.dts
+++ b/arch/arm/boot/dts/omap5-evm.dts
@@ -15,7 +15,7 @@
 
 	memory {
 		device_type = "memory";
-		reg = <0x80000000 0x40000000>; /* 1 GB */
+		reg = <0x80000000 0x80000000>; /* 2 GB */
 	};
 
 	vmmcsd_fixed: fixedregulator-mmcsd {
-- 
1.7.10.4

[PATCH V2 2/3] ARM: dts: omap5: EMIF device tree data for OMAP5 boards

[Lokesh Vutla]

Adding EMIF device tree data for OMAP5 boards.

Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
 arch/arm/boot/dts/omap5.dtsi |   24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
index 5db33f4..445aeea 100644
--- a/arch/arm/boot/dts/omap5.dtsi
+++ b/arch/arm/boot/dts/omap5.dtsi
@@ -319,5 +319,29 @@
 			ti,buffer-size = <128>;
 			ti,hwmods = "mcbsp3";
 		};
+
+		emif1: emif@0x4c000000 {
+			compatible	= "ti,emif-4d5";
+			ti,hwmods	= "emif1";
+			phy-type	= <2>;
+			reg = <0x4c000000 0x3ff>;
+			interrupts = <0 110 0x4>;
+			interrupt-parent = <&gic>;
+			hw-caps-read-idle-ctrl;
+			hw-caps-ll-interface;
+			hw-caps-temp-alert;
+		};
+
+		emif2: emif@0x4d000000 {
+			compatible	= "ti,emif-4d5";
+			ti,hwmods	= "emif2";
+			phy-type	= <2>;
+			reg = <0x4d000000 0x3ff>;
+			interrupts = <0 111 0x4>;
+			interrupt-parent = <&gic>;
+			hw-caps-read-idle-ctrl;
+			hw-caps-ll-interface;
+			hw-caps-temp-alert;
+		};
 	};
 };
-- 
1.7.10.4

Re: [PATCH V2 2/3] ARM: dts: omap5: EMIF device tree data for OMAP5 boards

[Benoit Cousson]

On 10/11/2012 02:47 PM, Lokesh Vutla wrote:
> Adding EMIF device tree data for OMAP5 boards.
> 
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
>  arch/arm/boot/dts/omap5.dtsi |   24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> index 5db33f4..445aeea 100644
> --- a/arch/arm/boot/dts/omap5.dtsi
> +++ b/arch/arm/boot/dts/omap5.dtsi
> @@ -319,5 +319,29 @@
>  			ti,buffer-size = <128>;
>  			ti,hwmods = "mcbsp3";
>  		};
> +
> +		emif1: emif@0x4c000000 {
> +			compatible	= "ti,emif-4d5";
> +			ti,hwmods	= "emif1";
> +			phy-type	= <2>;
> +			reg = <0x4c000000 0x3ff>;

Should 0x400. This parameter is the size, not the end address.

> +			interrupts = <0 110 0x4>;
> +			interrupt-parent = <&gic>;

Please remove the interrupt-parent. It is not needed since DT will use
the parent node to get it. It will avoid duplicating the entry for every
nodes.

> +			hw-caps-read-idle-ctrl;
> +			hw-caps-ll-interface;
> +			hw-caps-temp-alert;
> +		};
> +
> +		emif2: emif@0x4d000000 {
> +			compatible	= "ti,emif-4d5";
> +			ti,hwmods	= "emif2";
> +			phy-type	= <2>;

Can you just add a comment to give more information. I know this is in
the binding documentation, but some more comment never hurt.

> +			reg = <0x4d000000 0x3ff>;

0x400 as well.

> +			interrupts = <0 111 0x4>;
> +			interrupt-parent = <&gic>;

Ditto.

> +			hw-caps-read-idle-ctrl;
> +			hw-caps-ll-interface;
> +			hw-caps-temp-alert;
> +		};
>  	};
>  };
> 

Regards,
Benoit

[PATCH V2 3/3] ARM: dts: omap5-evm: LPDDR2 memory device details for EVM

[Lokesh Vutla]

Samsung's K3PE0E000B memory part is used in OMAP5-evm board.
Adding timings and geometry details for Samsung's memory part and
attaching the same to device-handle of EMIF1/2.

Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
 arch/arm/boot/dts/omap5-evm.dts           |   11 +++++
 arch/arm/boot/dts/samsung_k3pe0e000b.dtsi |   67 +++++++++++++++++++++++++++++
 2 files changed, 78 insertions(+)
 create mode 100644 arch/arm/boot/dts/samsung_k3pe0e000b.dtsi

diff --git a/arch/arm/boot/dts/omap5-evm.dts b/arch/arm/boot/dts/omap5-evm.dts
index 6f87e1a..ed1d1b5 100644
--- a/arch/arm/boot/dts/omap5-evm.dts
+++ b/arch/arm/boot/dts/omap5-evm.dts
@@ -8,6 +8,7 @@
 /dts-v1/;
 
 /include/ "omap5.dtsi"
+/include/ "samsung_k3pe0e000b.dtsi"
 
 / {
 	model = "TI OMAP5 EVM board";
@@ -82,3 +83,13 @@
 			0x020700d9>;	/* SEARCH */
 	linux,input-no-autorepeat;
 };
+
+&emif1 {
+	cs1-used;
+	device-handle = <&samsung_K3PE0E000B>;
+};
+
+&emif2 {
+	cs1-used;
+	device-handle = <&samsung_K3PE0E000B>;
+};
diff --git a/arch/arm/boot/dts/samsung_k3pe0e000b.dtsi b/arch/arm/boot/dts/samsung_k3pe0e000b.dtsi
new file mode 100644
index 0000000..b352d69
--- /dev/null
+++ b/arch/arm/boot/dts/samsung_k3pe0e000b.dtsi
@@ -0,0 +1,67 @@
+/*
+ * Timings and Geometry for Samsung K3PE0E000B memory part
+ */
+
+/ {
+	samsung_K3PE0E000B: lpddr2 {
+		compatible	= "Samsung,K3PE0E000B","jedec,lpddr2-s4";
+		density		= <4096>;
+		io-width	= <32>;
+
+		tRPab-min-tck	= <3>;
+		tRCD-min-tck	= <3>;
+		tWR-min-tck	= <3>;
+		tRASmin-min-tck	= <3>;
+		tRRD-min-tck	= <2>;
+		tWTR-min-tck	= <2>;
+		tXP-min-tck	= <2>;
+		tRTP-min-tck	= <2>;
+		tCKE-min-tck	= <3>;
+		tCKESR-min-tck	= <3>;
+		tFAW-min-tck	= <8>;
+
+		timings_samsung_K3PE0E000B_533mhz: lpddr2-timings@0 {
+			compatible	= "jedec,lpddr2-timings";
+			min-freq	= <10000000>;
+			max-freq	= <533333333>;
+			tRPab		= <21000>;
+			tRCD		= <18000>;
+			tWR		= <15000>;
+			tRAS-min	= <42000>;
+			tRRD		= <10000>;
+			tWTR		= <7500>;
+			tXP		= <7500>;
+			tRTP		= <7500>;
+			tCKESR		= <15000>;
+			tDQSCK-max	= <5500>;
+			tFAW		= <50000>;
+			tZQCS		= <90000>;
+			tZQCL		= <360000>;
+			tZQinit		= <1000000>;
+			tRAS-max-ns	= <70000>;
+			tDQSCK-max-derated = <6000>;
+		};
+
+		timings_samsung_K3PE0E000B_266mhz: lpddr2-timings@1 {
+			compatible	= "jedec,lpddr2-timings";
+			min-freq	= <10000000>;
+			max-freq	= <266666666>;
+			tRPab		= <21000>;
+			tRCD		= <18000>;
+			tWR		= <15000>;
+			tRAS-min	= <42000>;
+			tRRD		= <10000>;
+			tWTR		= <7500>;
+			tXP		= <7500>;
+			tRTP		= <7500>;
+			tCKESR		= <15000>;
+			tDQSCK-max	= <5500>;
+			tFAW		= <50000>;
+			tZQCS		= <90000>;
+			tZQCL		= <360000>;
+			tZQinit		= <1000000>;
+			tRAS-max-ns	= <70000>;
+			tDQSCK-max-derated = <6000>;
+		};
+	};
+};
-- 
1.7.10.4

Re: [PATCH V2 3/3] ARM: dts: omap5-evm: LPDDR2 memory device details for EVM

[Benoit Cousson]

On 10/11/2012 02:47 PM, Lokesh Vutla wrote:
> Samsung's K3PE0E000B memory part is used in OMAP5-evm board.
> Adding timings and geometry details for Samsung's memory part and
> attaching the same to device-handle of EMIF1/2.
> 
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
>  arch/arm/boot/dts/omap5-evm.dts           |   11 +++++
>  arch/arm/boot/dts/samsung_k3pe0e000b.dtsi |   67 +++++++++++++++++++++++++++++
>  2 files changed, 78 insertions(+)
>  create mode 100644 arch/arm/boot/dts/samsung_k3pe0e000b.dtsi
> 
> diff --git a/arch/arm/boot/dts/omap5-evm.dts b/arch/arm/boot/dts/omap5-evm.dts
> index 6f87e1a..ed1d1b5 100644
> --- a/arch/arm/boot/dts/omap5-evm.dts
> +++ b/arch/arm/boot/dts/omap5-evm.dts
> @@ -8,6 +8,7 @@
>  /dts-v1/;
>  
>  /include/ "omap5.dtsi"
> +/include/ "samsung_k3pe0e000b.dtsi"
>  
>  / {
>  	model = "TI OMAP5 EVM board";
> @@ -82,3 +83,13 @@
>  			0x020700d9>;	/* SEARCH */
>  	linux,input-no-autorepeat;
>  };
> +
> +&emif1 {
> +	cs1-used;
> +	device-handle = <&samsung_K3PE0E000B>;
> +};
> +
> +&emif2 {
> +	cs1-used;
> +	device-handle = <&samsung_K3PE0E000B>;
> +};
> diff --git a/arch/arm/boot/dts/samsung_k3pe0e000b.dtsi b/arch/arm/boot/dts/samsung_k3pe0e000b.dtsi
> new file mode 100644
> index 0000000..b352d69
> --- /dev/null
> +++ b/arch/arm/boot/dts/samsung_k3pe0e000b.dtsi
> @@ -0,0 +1,67 @@
> +/*
> + * Timings and Geometry for Samsung K3PE0E000B memory part
> + */
> +
> +/ {
> +	samsung_K3PE0E000B: lpddr2 {
> +		compatible	= "Samsung,K3PE0E000B","jedec,lpddr2-s4";
> +		density		= <4096>;
> +		io-width	= <32>;
> +
> +		tRPab-min-tck	= <3>;
> +		tRCD-min-tck	= <3>;
> +		tWR-min-tck	= <3>;
> +		tRASmin-min-tck	= <3>;
> +		tRRD-min-tck	= <2>;
> +		tWTR-min-tck	= <2>;
> +		tXP-min-tck	= <2>;
> +		tRTP-min-tck	= <2>;
> +		tCKE-min-tck	= <3>;
> +		tCKESR-min-tck	= <3>;
> +		tFAW-min-tck	= <8>;
> +
> +		timings_samsung_K3PE0E000B_533mhz: lpddr2-timings@0 {

Nit, but the official unit is: MHz [1].


Regards,
Benoit

[1] http://www.bipm.org/utils/common/pdf/si_brochure_8_en.pdf

Re: [PATCH V2 0/3] ARM: dts: omap5: EMIF and LPDDR2 device tree data

[Lokesh Vutla]

Hi,
On Thursday 11 October 2012 06:17 PM, Lokesh Vutla wrote:
> This patch series adds Device tree data for the EMIF
> sdram controllers in OMAP5 and LPDDR2 memory devices
> in OMAP5-evm board.
>
> Testing:
> - Boot tested on OMAP5430 evm.
> - Built EMIF as a module.
>
> Changes from v1:
> * Created a seperate dtsi file for Samsung LPDDR2 memory device
>    used in OMAP5-evm.
> * Passing reg and interrupt fields from dt for EMIF1 and EMIF2.
Gentle ping on this series.

Thanks
Lokesh
>
> Lokesh Vutla (3):
>    ARM: dts: omap5-evm: Fix size of memory defined for EVM
>    ARM: dts: omap5: EMIF device tree data for OMAP5 boards
>    ARM: dts: omap5-evm: LPDDR2 memory device details for EVM
>
>   arch/arm/boot/dts/omap5-evm.dts           |   13 +++++-
>   arch/arm/boot/dts/omap5.dtsi              |   24 +++++++++++
>   arch/arm/boot/dts/samsung_k3pe0e000b.dtsi |   67 +++++++++++++++++++++++++++++
>   3 files changed, 103 insertions(+), 1 deletion(-)
>   create mode 100644 arch/arm/boot/dts/samsung_k3pe0e000b.dtsi
>

Re: [PATCH V2 0/3] ARM: dts: omap5: EMIF and LPDDR2 device tree data

[Benoit Cousson]

Hi Lokesh,

On 11/05/2012 06:58 AM, Lokesh Vutla wrote:
> Hi,
> On Thursday 11 October 2012 06:17 PM, Lokesh Vutla wrote:
>> This patch series adds Device tree data for the EMIF
>> sdram controllers in OMAP5 and LPDDR2 memory devices
>> in OMAP5-evm board.
>>
>> Testing:
>> - Boot tested on OMAP5430 evm.
>> - Built EMIF as a module.
>>
>> Changes from v1:
>> * Created a seperate dtsi file for Samsung LPDDR2 memory device
>>    used in OMAP5-evm.
>> * Passing reg and interrupt fields from dt for EMIF1 and EMIF2.
> Gentle ping on this series.

Sorry, I missed it. It might be too late for 3.8, since Tony wanted us
to push before -rc4. I'll pull the series anyway just in case.

I have a least one comment.

Regards,
Benoit

> 
> Thanks
> Lokesh
>>
>> Lokesh Vutla (3):
>>    ARM: dts: omap5-evm: Fix size of memory defined for EVM
>>    ARM: dts: omap5: EMIF device tree data for OMAP5 boards
>>    ARM: dts: omap5-evm: LPDDR2 memory device details for EVM
>>
>>   arch/arm/boot/dts/omap5-evm.dts           |   13 +++++-
>>   arch/arm/boot/dts/omap5.dtsi              |   24 +++++++++++
>>   arch/arm/boot/dts/samsung_k3pe0e000b.dtsi |   67
>> +++++++++++++++++++++++++++++
>>   3 files changed, 103 insertions(+), 1 deletion(-)
>>   create mode 100644 arch/arm/boot/dts/samsung_k3pe0e000b.dtsi
>>
> 

Re: [PATCH V2 0/3] ARM: dts: omap5: EMIF and LPDDR2 device tree data

[Benoit Cousson]

On 11/05/2012 11:51 AM, Benoit Cousson wrote:
> Hi Lokesh,
> 
> On 11/05/2012 06:58 AM, Lokesh Vutla wrote:
>> Hi,
>> On Thursday 11 October 2012 06:17 PM, Lokesh Vutla wrote:
>>> This patch series adds Device tree data for the EMIF
>>> sdram controllers in OMAP5 and LPDDR2 memory devices
>>> in OMAP5-evm board.
>>>
>>> Testing:
>>> - Boot tested on OMAP5430 evm.
>>> - Built EMIF as a module.
>>>
>>> Changes from v1:
>>> * Created a seperate dtsi file for Samsung LPDDR2 memory device
>>>    used in OMAP5-evm.
>>> * Passing reg and interrupt fields from dt for EMIF1 and EMIF2.
>> Gentle ping on this series.
> 
> Sorry, I missed it. It might be too late for 3.8, since Tony wanted us
> to push before -rc4. I'll pull the series anyway just in case.
> 
> I have a least one comment.

Could you just rebase on top of the for_3.8 branch, fix the minor
comments and repost ASAP.

Thanks,
Benoit

Re: [PATCH V2 0/3] ARM: dts: omap5: EMIF and LPDDR2 device tree data

[Lokesh Vutla]

Hi Benoit,

On Monday 05 November 2012 04:33 PM, Benoit Cousson wrote:
> On 11/05/2012 11:51 AM, Benoit Cousson wrote:
>> Hi Lokesh,
>>
>> On 11/05/2012 06:58 AM, Lokesh Vutla wrote:
>>> Hi,
>>> On Thursday 11 October 2012 06:17 PM, Lokesh Vutla wrote:
>>>> This patch series adds Device tree data for the EMIF
>>>> sdram controllers in OMAP5 and LPDDR2 memory devices
>>>> in OMAP5-evm board.
>>>>
>>>> Testing:
>>>> - Boot tested on OMAP5430 evm.
>>>> - Built EMIF as a module.
>>>>
>>>> Changes from v1:
>>>> * Created a seperate dtsi file for Samsung LPDDR2 memory device
>>>>     used in OMAP5-evm.
>>>> * Passing reg and interrupt fields from dt for EMIF1 and EMIF2.
>>> Gentle ping on this series.
>>
>> Sorry, I missed it. It might be too late for 3.8, since Tony wanted us
>> to push before -rc4. I'll pull the series anyway just in case.
>>
>> I have a least one comment.
>
> Could you just rebase on top of the for_3.8 branch, fix the minor
> comments and repost ASAP.
OK I ll rebase and repost.

Thanks
Lokesh
>
> Thanks,
> Benoit
>