From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mugunthan V N Subject: Re: [PATCH 3/7] ARM: OMAP3+: hwmod: Add AM33XX HWMOD data for davinci_mdio module Date: Tue, 6 Nov 2012 19:00:42 +0530 Message-ID: <50991102.3080302@ti.com> References: <1352189545-26303-1-git-send-email-mugunthanvnm@ti.com> <1352189545-26303-4-git-send-email-mugunthanvnm@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-omap-owner@vger.kernel.org To: "Bedia, Vaibhav" Cc: "netdev@vger.kernel.org" , Richard Cochran , Paul Walmsley , "devicetree-discuss@lists.ozlabs.org" , "Hiremath, Vaibhav" , "linux-omap@vger.kernel.org" , "davem@davemloft.net" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On 11/6/2012 3:39 PM, Bedia, Vaibhav wrote: > On Tue, Nov 06, 2012 at 13:42:21, N, Mugunthan V wrote: > [...] >> +struct omap_hwmod_addr_space am33xx_mdio_addr_space[] = { >> + { >> + .pa_start = 0x4A101000, >> + .pa_end = 0x4A101000 + SZ_256 - 1, >> + .flags = ADDR_MAP_ON_INIT, > Based on the recent discussions and looking the hwmod code, > I guess ADDR_MAP_ON_INIT does not make sense here. Since you > are just creating a parent-child relationship here, maybe no > flag is needed? Will remove this flag as it is a parrent-child relationship > >> + }, >> + { } >> +}; >> + >> +struct omap_hwmod_ocp_if am33xx_cpgmac0__mdio = { >> + .master = &am33xx_cpgmac0_hwmod, >> + .slave = &am33xx_mdio_hwmod, >> + .addr = am33xx_mdio_addr_space, >> + .user = OCP_USER_MPU, > Is this flag necessary? Shouldn't you just skip the > user field since there's nothing for the hwmod code > to do here? This flag is necessary as MPU is going to access to device. The patch will look like @@ -2501,6 +2516,21 @@ static struct omap_hwmod_ocp_if am33xx_l4_hs__cpgmac0 = { .user = OCP_USER_MPU, }; +struct omap_hwmod_addr_space am33xx_mdio_addr_space[] = { + { + .pa_start = 0x4A101000, + .pa_end = 0x4A101000 + SZ_256 - 1, + }, + { } +}; + +struct omap_hwmod_ocp_if am33xx_cpgmac0__mdio = { + .master = &am33xx_cpgmac0_hwmod, + .slave = &am33xx_mdio_hwmod, + .addr = am33xx_mdio_addr_space, + .user = OCP_USER_MPU, +}; + static struct omap_hwmod_addr_space am33xx_elm_addr_space[] = { { .pa_start = 0x48080000, Regards Mugunthan V N