From: Stephen Warren <swarren@wwwdotorg.org>
To: Marek Belisko <marek.belisko@open-nandra.com>
Cc: cooloney@gmail.com, rpurdie@rpsys.net,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH v2 2/2] Add documentation for tca6507 devicetree bindings.
Date: Wed, 07 Nov 2012 16:14:33 -0700 [thread overview]
Message-ID: <509AEB59.7010504@wwwdotorg.org> (raw)
In-Reply-To: <1352321726-21284-2-git-send-email-marek.belisko@open-nandra.com>
On 11/07/2012 01:55 PM, Marek Belisko wrote:
> diff --git a/Documentation/devicetree/bindings/leds/tca6507.txt b/Documentation/devicetree/bindings/leds/tca6507.txt
> +LEDs conected to tca6507
> +
> +Required properties:
> +- compatible : should be : "leds-tca6507".
"ti,tca6507" would be more typical.
> +Each led is represented as a sub-node of the leds-tca6507 device.
> +
> +LED sub-node properties:
> +- label : label for this LED
> +- reg : number of LED line (could be from 0 to 6)
> +- linux,default-trigger : led default trigger
You probably want to mention which binding document defines the valid
values for that property; ../gpio/led.txt I think.
I wonder if we need to think about representing the blinking/fading/...
capabilities of the chip too? Should that be encoded into the DT, or
should it be controlled at run-time via some LED subsystem?
next prev parent reply other threads:[~2012-11-07 23:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 20:55 [PATCH v2 1/2] leds/tca6507: Add support for devicetree Marek Belisko
2012-11-07 20:55 ` [PATCH v2 2/2] Add documentation for tca6507 devicetree bindings Marek Belisko
2012-11-07 23:14 ` Stephen Warren [this message]
[not found] ` <509AEB59.7010504-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-11-08 19:51 ` Belisko Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509AEB59.7010504@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=cooloney@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marek.belisko@open-nandra.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).