From: Fabio Estevam <festevam@denx.de>
To: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>,
shawnguo@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: imx6sx: Add LDB support
Date: Wed, 17 May 2023 20:45:09 -0300 [thread overview]
Message-ID: <509c272d28cf3e6f642115fb424e51bc@denx.de> (raw)
In-Reply-To: <16ecb29a-4d52-9464-ecb0-2e45262af105@denx.de>
Hi Marek,
On 17/05/2023 20:15, Marek Vasut wrote:
>> diff --git a/arch/arm/boot/dts/imx6sx.dtsi
>> b/arch/arm/boot/dts/imx6sx.dtsi
>> index 4233943a1cca..7a8a00d81666 100644
>> --- a/arch/arm/boot/dts/imx6sx.dtsi
>> +++ b/arch/arm/boot/dts/imx6sx.dtsi
>> @@ -843,8 +843,39 @@ iomuxc: pinctrl@20e0000 {
>> gpr: iomuxc-gpr@20e4000 {
>> compatible = "fsl,imx6sx-iomuxc-gpr",
>> - "fsl,imx6q-iomuxc-gpr", "syscon";
>> + "fsl,imx6q-iomuxc-gpr", "simple-bus", "syscon";
>
> Can we really combine simple-bus and syscon or do we need something
> like
Thanks for your review.
> 5a51e1f2b0834 ("arm64: dts: imx8mp: Drop simple-bus from
> fsl,imx8mp-media-blk-ctrl")
As is, if simple-bus is dropped, the LDB bus is not probed.
> 9cb6d1b39a8f5 ("soc: imx: imx8m-blk-ctrl: Scan subnodes and bind
> drivers to them")
On the i.MX6SX, I am not sure we can add devm_of_platform_populate()
like in the
imx8m-blk-ctrl case.
imx8m-blk-ctrl has a probe function, but imx6q-iomuxc-gpr does not.
Thanks
next prev parent reply other threads:[~2023-05-17 23:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 21:02 [PATCH] ARM: dts: imx6sx: Add LDB support Fabio Estevam
2023-05-17 23:15 ` Marek Vasut
2023-05-17 23:45 ` Fabio Estevam [this message]
2023-05-18 7:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509c272d28cf3e6f642115fb424e51bc@denx.de \
--to=festevam@denx.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).