* [RFC PATCH 3.7.0-rc4 2/4] mm:exynos: use of_simple_module_id_table macro.
@ 2012-11-16 13:21 Srinivas KANDAGATLA
2012-11-16 13:30 ` Girish K S
0 siblings, 1 reply; 3+ messages in thread
From: Srinivas KANDAGATLA @ 2012-11-16 13:21 UTC (permalink / raw)
To: grant.likely, rob.herring, viresh.linux, g.liakhovetski, ian,
thomas.ab
Cc: srinivas.kandagatla, spear-devel, linux-mmc, devicetree-discuss
From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
This patch uses of_simple_module_id_table macro to replace code like:
#ifdef CONFIG_OF
static struct of_device_id xxx_of_match[] = {
{ .compatible = "yyy,xxx" },
{ },
};
MODULE_DEVICE_TABLE(of, xxx_of_match);
#endif
with
of_simple_module_id_table(xxx_of_match, "yyy,zzz");
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
---
drivers/mmc/host/dw_mmc-exynos.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
index 660bbc5..1e9596a 100644
--- a/drivers/mmc/host/dw_mmc-exynos.c
+++ b/drivers/mmc/host/dw_mmc-exynos.c
@@ -218,12 +218,7 @@ static struct dw_mci_drv_data exynos5250_drv_data = {
.setup_bus = dw_mci_exynos_setup_bus,
};
-static const struct of_device_id dw_mci_exynos_match[] = {
- { .compatible = "samsung,exynos5250-dw-mshc",
- .data = (void *)&exynos5250_drv_data, },
- {},
-};
-MODULE_DEVICE_TABLE(of, dw_mci_pltfm_match);
+of_simple_module_id_table(dw_mci_pltfm_match, "samsung,exynos5250-dw-mshc");
int dw_mci_exynos_probe(struct platform_device *pdev)
{
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH 3.7.0-rc4 2/4] mm:exynos: use of_simple_module_id_table macro.
2012-11-16 13:21 [RFC PATCH 3.7.0-rc4 2/4] mm:exynos: use of_simple_module_id_table macro Srinivas KANDAGATLA
@ 2012-11-16 13:30 ` Girish K S
2012-11-16 13:37 ` Srinivas KANDAGATLA
0 siblings, 1 reply; 3+ messages in thread
From: Girish K S @ 2012-11-16 13:30 UTC (permalink / raw)
To: Srinivas KANDAGATLA
Cc: grant.likely, rob.herring, viresh.linux, g.liakhovetski, ian,
thomas.ab, spear-devel, linux-mmc, devicetree-discuss
On 16 November 2012 18:51, Srinivas KANDAGATLA
<srinivas.kandagatla@st.com> wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>
> This patch uses of_simple_module_id_table macro to replace code like:
>
> #ifdef CONFIG_OF
> static struct of_device_id xxx_of_match[] = {
> { .compatible = "yyy,xxx" },
> { },
> };
> MODULE_DEVICE_TABLE(of, xxx_of_match);
> #endif
>
> with
> of_simple_module_id_table(xxx_of_match, "yyy,zzz");
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
> ---
> drivers/mmc/host/dw_mmc-exynos.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> index 660bbc5..1e9596a 100644
> --- a/drivers/mmc/host/dw_mmc-exynos.c
> +++ b/drivers/mmc/host/dw_mmc-exynos.c
> @@ -218,12 +218,7 @@ static struct dw_mci_drv_data exynos5250_drv_data = {
> .setup_bus = dw_mci_exynos_setup_bus,
> };
>
> -static const struct of_device_id dw_mci_exynos_match[] = {
> - { .compatible = "samsung,exynos5250-dw-mshc",
> - .data = (void *)&exynos5250_drv_data, },
> - {},
> -};
Here's the problem. You are missing the driver data for the exynos
SoC. this is very much required.
where's the .data = (void *)&exynos5250_drv_data,?
> -MODULE_DEVICE_TABLE(of, dw_mci_pltfm_match);
> +of_simple_module_id_table(dw_mci_pltfm_match, "samsung,exynos5250-dw-mshc");
>
> int dw_mci_exynos_probe(struct platform_device *pdev)
> {
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH 3.7.0-rc4 2/4] mm:exynos: use of_simple_module_id_table macro.
2012-11-16 13:30 ` Girish K S
@ 2012-11-16 13:37 ` Srinivas KANDAGATLA
0 siblings, 0 replies; 3+ messages in thread
From: Srinivas KANDAGATLA @ 2012-11-16 13:37 UTC (permalink / raw)
To: Girish K S
Cc: grant.likely, rob.herring, viresh.linux, g.liakhovetski, ian,
thomas.ab, spear-devel, linux-mmc, devicetree-discuss
On 16/11/12 13:30, Girish K S wrote:
> On 16 November 2012 18:51, Srinivas KANDAGATLA
> <srinivas.kandagatla@st.com> wrote:
>> From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>>
>> This patch uses of_simple_module_id_table macro to replace code like:
>>
>> #ifdef CONFIG_OF
>> static struct of_device_id xxx_of_match[] = {
>> { .compatible = "yyy,xxx" },
>> { },
>> };
>> MODULE_DEVICE_TABLE(of, xxx_of_match);
>> #endif
>>
>> with
>> of_simple_module_id_table(xxx_of_match, "yyy,zzz");
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>> ---
>> drivers/mmc/host/dw_mmc-exynos.c | 7 +------
>> 1 files changed, 1 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
>> index 660bbc5..1e9596a 100644
>> --- a/drivers/mmc/host/dw_mmc-exynos.c
>> +++ b/drivers/mmc/host/dw_mmc-exynos.c
>> @@ -218,12 +218,7 @@ static struct dw_mci_drv_data exynos5250_drv_data = {
>> .setup_bus = dw_mci_exynos_setup_bus,
>> };
>>
>> -static const struct of_device_id dw_mci_exynos_match[] = {
>> - { .compatible = "samsung,exynos5250-dw-mshc",
>> - .data = (void *)&exynos5250_drv_data, },
>> - {},
>> -};
> Here's the problem. You are missing the driver data for the exynos
> SoC. this is very much required.
> where's the .data = (void *)&exynos5250_drv_data,?
Thanks for looking,
Yep, You are correct.
>> -MODULE_DEVICE_TABLE(of, dw_mci_pltfm_match);
>> +of_simple_module_id_table(dw_mci_pltfm_match, "samsung,exynos5250-dw-mshc");
>>
>> int dw_mci_exynos_probe(struct platform_device *pdev)
>> {
>> --
>> 1.7.0.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-16 13:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-16 13:21 [RFC PATCH 3.7.0-rc4 2/4] mm:exynos: use of_simple_module_id_table macro Srinivas KANDAGATLA
2012-11-16 13:30 ` Girish K S
2012-11-16 13:37 ` Srinivas KANDAGATLA
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).