From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Wenyou Yang <wenyou.yang@atmel.com>,
Fabio Porcedda <fabio.porcedda@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-watchdog@vger.kernel.org, JM.Lin@atmel.com,
linux-kernel@vger.kernel.org, rob.herring@calxeda.com,
grant.likely@secretlab.ca, wim@iguana.be, plagnioj@jcrosoft.com,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH 09/11] watchdog/at91sam9_wdt: add support to device tree
Date: Fri, 16 Nov 2012 14:56:52 +0100 [thread overview]
Message-ID: <50A64624.6010902@atmel.com> (raw)
In-Reply-To: <1352877369-19740-10-git-send-email-wenyou.yang@atmel.com>
On 11/14/2012 08:16 AM, Wenyou Yang :
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
No. The work has already been done by Fabio Porcedda and he managed to
sustain the discussion and reach a consensus at his v9 patch series: so
please take into account his work and build yours on top of his patch
series.
Best regards,
> Cc: grant.likely@secretlab.ca
> Cc: rob.herring@calxeda.com
> Cc: devicetree-discuss@lists.ozlabs.org
> ---
> drivers/watchdog/at91sam9_wdt.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/watchdog/at91sam9_wdt.c b/drivers/watchdog/at91sam9_wdt.c
> index e7ce9ea..cba5c5d 100644
> --- a/drivers/watchdog/at91sam9_wdt.c
> +++ b/drivers/watchdog/at91sam9_wdt.c
> @@ -32,6 +32,7 @@
> #include <linux/jiffies.h>
> #include <linux/timer.h>
> #include <linux/bitops.h>
> +#include <linux/of.h>
>
> #include "at91sam9_wdt.h"
>
> @@ -251,12 +252,21 @@ static int __exit at91wdt_remove(struct platform_device *pdev)
> return 0;
> }
>
> +#ifdef CONFIG_OF
> +static const struct of_device_id at91wdt_match[] = {
> + { .compatible = "atmel,at91sam-wdt" },
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, at91wdt_match);
> +#endif
> +
> static struct platform_driver at91wdt_driver = {
> .probe = at91wdt_probe,
> .remove = __exit_p(at91wdt_remove),
> .driver = {
> .name = "at91_wdt",
> .owner = THIS_MODULE,
> + .of_match_table = of_match_ptr(at91wdt_match),
> },
> };
>
>
--
Nicolas Ferre
next prev parent reply other threads:[~2012-11-16 13:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1352877369-19740-1-git-send-email-wenyou.yang@atmel.com>
2012-11-14 7:16 ` [PATCH 09/11] watchdog/at91sam9_wdt: add support to device tree Wenyou Yang
2012-11-16 13:56 ` Nicolas Ferre [this message]
2012-11-14 7:16 ` [PATCH 11/11] ARM: dts: add the watchdog nodes for atmel SoC Wenyou Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A64624.6010902@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=JM.Lin@atmel.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=fabio.porcedda@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=rob.herring@calxeda.com \
--cc=wenyou.yang@atmel.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).