From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Gortmaker Subject: Re: [PATCH v6 3/4] media: coda: use genalloc API Date: Fri, 16 Nov 2012 11:00:07 -0500 Message-ID: <50A66307.3080706@windriver.com> References: <1353061817-3207-1-git-send-email-p.zabel@pengutronix.de> <1353061817-3207-4-git-send-email-p.zabel@pengutronix.de> <50A656E2.707@windriver.com> <1353079273.2413.160.camel@pizza.hi.pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1353079273.2413.160.camel-/rZezPiN1rtR6QfukMTsflXZhhPuCNm+@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Philipp Zabel Cc: Fabio Estevam , Matt Porter , Dong Aisheng , Greg Kroah-Hartman , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Richard Zhao , Javier Martin , kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, Huang Shijie List-Id: devicetree@vger.kernel.org On 12-11-16 10:21 AM, Philipp Zabel wrote: > Am Freitag, den 16.11.2012, 10:08 -0500 schrieb Paul Gortmaker: >> On 12-11-16 05:30 AM, Philipp Zabel wrote: >>> This patch depends on "genalloc: add a global pool list, >>> allow to find pools by phys address", which provides the >>> of_get_named_gen_pool function. >>> >>> Signed-off-by: Philipp Zabel >>> --- >>> drivers/media/platform/Kconfig | 3 +-- >>> drivers/media/platform/coda.c | 47 ++++++++++++++++++++++++++++------------ >>> 2 files changed, 34 insertions(+), 16 deletions(-) >>> >>> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig >>> index 181c768..09d45c6 100644 >>> --- a/drivers/media/platform/Kconfig >>> +++ b/drivers/media/platform/Kconfig >>> @@ -130,10 +130,9 @@ if V4L_MEM2MEM_DRIVERS >>> >>> config VIDEO_CODA >>> tristate "Chips&Media Coda multi-standard codec IP" >>> - depends on VIDEO_DEV && VIDEO_V4L2 && ARCH_MXC >>> + depends on VIDEO_DEV && VIDEO_V4L2 >> >> What was the logic for reducing the dependency scope here? >> Your commit log doesn't mention that at all, and when I see >> things like that, I predict allyesconfig build failures, >> unless there is a similar dependency elsewhere that isn't >> visible in just the context of this patch alone. >> >> P. > > iram_alloc and iram_free are i.MX specific wrappers around > gen_pool_alloc and gen_pool_free, located in . > Those were responsible for the dependency in the first place. So when I do an allyesconfig for sparc, or parisc or alpha, and VIDEO_CODA gets selected, it will build just fine then? My point was that when you remove the ARCH_MXC dep, this probably gets opened up as a viable option to a _lot_ more platforms than you might want it exposed to. Paul. -- > >> -- >> >>> select VIDEOBUF2_DMA_CONTIG >>> select V4L2_MEM2MEM_DEV >>> - select IRAM_ALLOC if SOC_IMX53 >>> ---help--- >>> Coda is a range of video codec IPs that supports >>> H.264, MPEG-4, and other video formats. >>> diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c >>> index cd04ae2..f17b659 100644 >>> --- a/drivers/media/platform/coda.c >>> +++ b/drivers/media/platform/coda.c >>> @@ -14,6 +14,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> #include >>> #include >>> #include >>> @@ -24,7 +25,6 @@ >>> #include >>> #include >>> >>> -#include > [...] > > After dropping the #include , there is no need > to depend on ARCH_MXC anymore. > > regards > Philipp >