From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH -next] iio: isl29018: fix to return error or 0 in isl29018_write_raw() Date: Sat, 17 Nov 2012 10:20:36 +0000 Message-ID: <50A764F4.3040008@kernel.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wei Yongjun Cc: jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org On 11/08/2012 09:05 AM, Wei Yongjun wrote: > From: Wei Yongjun > > We had assigned the return value to 'ret' but ignored it when > return from isl29018_write_raw(), it's better to return 'ret' > instead of 0. > > dpatch engine is used to auto generate this patch. > (https://github.com/weiyj/dpatch) > Thanks - merged to togreg branch of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git > Signed-off-by: Wei Yongjun > --- > drivers/staging/iio/light/isl29018.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c > index 3b03f6f..1d5b294 100644 > --- a/drivers/staging/iio/light/isl29018.c > +++ b/drivers/staging/iio/light/isl29018.c > @@ -356,7 +356,7 @@ static int isl29018_write_raw(struct iio_dev *indio_dev, > } > mutex_unlock(&chip->lock); > > - return 0; > + return ret; > } > > static int isl29018_read_raw(struct iio_dev *indio_dev, > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >