From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v5 1/8] dt: add helper inline for retrieving timeout-sec property Date: Tue, 20 Nov 2012 11:09:19 -0600 Message-ID: <50ABB93F.5070109@gmail.com> References: <1353334243-16703-1-git-send-email-fabio.porcedda@gmail.com> <1353334243-16703-2-git-send-email-fabio.porcedda@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1353334243-16703-2-git-send-email-fabio.porcedda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Fabio Porcedda Cc: Andrew Lunn , Kukjin Kim , linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Rob Herring , Wim Van Sebroeck , Ben Dooks , Andrew Victor , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Jason Cooper List-Id: devicetree@vger.kernel.org On 11/19/2012 08:10 AM, Fabio Porcedda wrote: > The first user of this function is the watchdog framework. I still have issues with this. In addition to questionable usefulness outside the watchdog framework, I'm not even sure this is right for watchdog framework. Watchdog timeout is not a description of h/w, but user configuration. I think the existing mechanisms of module param or kernel cmdline is the right way to handle this. Rob > Signed-off-by: Fabio Porcedda > Cc: Grant Likely > Cc: Rob Herring > --- > include/linux/of.h | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/include/linux/of.h b/include/linux/of.h > index b4e50d5..d60fde9 100644 > --- a/include/linux/of.h > +++ b/include/linux/of.h > @@ -477,4 +477,15 @@ static inline int of_property_read_u32(const struct device_node *np, > return of_property_read_u32_array(np, propname, out_value, 1); > } > > +/** > + * of_get_timeout_sec() - Helper to read the timeout_sec property > + * @np: device node from which the property value is to be read. > + * @timeout: adress of the output value > + */ > +static inline int of_get_timeout_sec(const struct device_node *np, > + u32 *timeout) > +{ > + return of_property_read_u32(np, "timeout-sec", timeout); > +} > + > #endif /* _LINUX_OF_H */ >