From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH] of_i2c: Honour "status=disabled" property of device Date: Wed, 28 Nov 2012 09:16:12 -0700 Message-ID: <50B638CC.6070106@wwwdotorg.org> References: <50B61DDA.5090109@sysgo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <50B61DDA.5090109-uSbOeAmDUekAvxtiuMwx3w@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alexander Sverdlin Cc: Jochen Friedrich , Jon Smirl , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Rob Herring , Grant Likely , alexander sverdlin List-Id: devicetree@vger.kernel.org On 11/28/2012 07:21 AM, Alexander Sverdlin wrote: > of_i2c: Honour "status=disabled" property of device > > Currently of_i2c_register_devices() function registers all i2c devices, > independently from their status property in device tree. According to > "ePAPR 1.1" spec, device should only be registered if there is no > "status" property, or it has "ok" (or "okay") value (see > of_device_is_available()). In case of "platform devices", > of_platform_device_create_pdata() checks for "status" and ensures > that disabled devices are not populated. But such check for i2c buses > was missing until now. Fix it. Do SPI and other buses (e.g. MDIO/MDIO mux?) need a similar change?