[PATCH] of_i2c: Honour "status=disabled" property of device

[PATCH] of_i2c: Honour "status=disabled" property of device

[Alexander Sverdlin]

From: Alexander Sverdlin <alexander.sverdlin-uSbOeAmDUekAvxtiuMwx3w@public.gmane.org>

of_i2c: Honour "status=disabled" property of device

Currently of_i2c_register_devices() function registers all i2c devices,
independently from their status property in device tree. According to
"ePAPR 1.1" spec, device should only be registered if there is no
"status" property, or it has "ok" (or "okay") value (see
of_device_is_available()). In case of "platform devices",
of_platform_device_create_pdata() checks for "status" and ensures
that disabled devices are not populated. But such check for i2c buses
was missing until now. Fix it.

Signed-off-by: Alexander Sverdlin <alexander.sverdlin-uSbOeAmDUekAvxtiuMwx3w@public.gmane.org>
---
--- linux.orig/drivers/of/of_i2c.c
+++ linux/drivers/of/of_i2c.c
@@ -29,7 +29,7 @@ void of_i2c_register_devices(struct i2c_
 
 	dev_dbg(&adap->dev, "of_i2c: walking child nodes\n");
 
-	for_each_child_of_node(adap->dev.of_node, node) {
+	for_each_available_child_of_node(adap->dev.of_node, node) {
 		struct i2c_board_info info = {};
 		struct dev_archdata dev_ad = {};
 		const __be32 *addr;

Re: [PATCH] of_i2c: Honour "status=disabled" property of device

[Stephen Warren]

On 11/28/2012 07:21 AM, Alexander Sverdlin wrote:
> of_i2c: Honour "status=disabled" property of device
> 
> Currently of_i2c_register_devices() function registers all i2c devices,
> independently from their status property in device tree. According to
> "ePAPR 1.1" spec, device should only be registered if there is no
> "status" property, or it has "ok" (or "okay") value (see
> of_device_is_available()). In case of "platform devices",
> of_platform_device_create_pdata() checks for "status" and ensures
> that disabled devices are not populated. But such check for i2c buses
> was missing until now. Fix it.

Do SPI and other buses (e.g. MDIO/MDIO mux?) need a similar change?

Re: [PATCH] of_i2c: Honour "status=disabled" property of device

[Alexander Sverdlin]

Hi!

On 11/28/2012 05:16 PM, Stephen Warren wrote:
> On 11/28/2012 07:21 AM, Alexander Sverdlin wrote:
>> of_i2c: Honour "status=disabled" property of device
>>
>> Currently of_i2c_register_devices() function registers all i2c devices,
>> independently from their status property in device tree. According to
>> "ePAPR 1.1" spec, device should only be registered if there is no
>> "status" property, or it has "ok" (or "okay") value (see
>> of_device_is_available()). In case of "platform devices",
>> of_platform_device_create_pdata() checks for "status" and ensures
>> that disabled devices are not populated. But such check for i2c buses
>> was missing until now. Fix it.
> 
> Do SPI and other buses (e.g. MDIO/MDIO mux?) need a similar change?

You are right, of_register_spi_devices() and of_mdiobus_register() both have exactly the same issue.
Should it be a follow-up patch, or better to combine them to one patch?

-- 
Best regards,
Alexander Sverdlin.

Re: [PATCH] of_i2c: Honour "status=disabled" property of device

[Rob Herring]

On 11/28/2012 10:51 AM, Alexander Sverdlin wrote:
> Hi!
> 
> On 11/28/2012 05:16 PM, Stephen Warren wrote:
>> On 11/28/2012 07:21 AM, Alexander Sverdlin wrote:
>>> of_i2c: Honour "status=disabled" property of device
>>>
>>> Currently of_i2c_register_devices() function registers all i2c devices,
>>> independently from their status property in device tree. According to
>>> "ePAPR 1.1" spec, device should only be registered if there is no
>>> "status" property, or it has "ok" (or "okay") value (see
>>> of_device_is_available()). In case of "platform devices",
>>> of_platform_device_create_pdata() checks for "status" and ensures
>>> that disabled devices are not populated. But such check for i2c buses
>>> was missing until now. Fix it.
>>
>> Do SPI and other buses (e.g. MDIO/MDIO mux?) need a similar change?
> 
> You are right, of_register_spi_devices() and of_mdiobus_register() both have exactly the same issue.
> Should it be a follow-up patch, or better to combine them to one patch?

Separate please in case there is some reason to revert. Also, I already
have a patch for i2c that does the same thing in my tree. However, your
patch is better, so I'll probably replace it with yours.

Rob

Re: [PATCH] of_i2c: Honour "status=disabled" property of device

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]

On Wed, Nov 28, 2012 at 03:21:14PM +0100, Alexander Sverdlin wrote:
> From: Alexander Sverdlin <alexander.sverdlin-uSbOeAmDUekAvxtiuMwx3w@public.gmane.org>
> 
> of_i2c: Honour "status=disabled" property of device
> 
> Currently of_i2c_register_devices() function registers all i2c devices,
> independently from their status property in device tree. According to
> "ePAPR 1.1" spec, device should only be registered if there is no
> "status" property, or it has "ok" (or "okay") value (see
> of_device_is_available()). In case of "platform devices",
> of_platform_device_create_pdata() checks for "status" and ensures
> that disabled devices are not populated. But such check for i2c buses
> was missing until now. Fix it.
> 
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin-uSbOeAmDUekAvxtiuMwx3w@public.gmane.org>

Seems like Rob wants to pick it, so:

Acked-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

RE: [PATCH] of_i2c: Honour "status=disabled" property of device

[Barry Song]

> -----Original Message-----
> From: devicetree-discuss
> [mailto:devicetree-discuss-bounces+bs14=csr.com@lists.ozlabs.org] On Behalf
> Of Alexander Sverdlin
> Sent: Wednesday, November 28, 2012 10:21 PM
> To: Jochen Friedrich; Jon Smirl; linux-i2c@vger.kernel.org;
> devicetree-discuss@lists.ozlabs.org; Rob Herring; Grant Likely
> Cc: alexander sverdlin
> Subject: [PATCH] of_i2c: Honour "status=disabled" property of device
> 
> From: Alexander Sverdlin <alexander.sverdlin@sysgo.com>
> 
> of_i2c: Honour "status=disabled" property of device
> 
> Currently of_i2c_register_devices() function registers all i2c devices,
> independently from their status property in device tree. According to
> "ePAPR 1.1" spec, device should only be registered if there is no
> "status" property, or it has "ok" (or "okay") value (see
> of_device_is_available()). In case of "platform devices",
> of_platform_device_create_pdata() checks for "status" and ensures
> that disabled devices are not populated. But such check for i2c buses
> was missing until now. Fix it.
> 
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@sysgo.com>
> ---

Reviewed-by: Barry Song <Baohua.Song@csr.com>

> --- linux.orig/drivers/of/of_i2c.c
> +++ linux/drivers/of/of_i2c.c
> @@ -29,7 +29,7 @@ void of_i2c_register_devices(struct i2c_
> 
>  	dev_dbg(&adap->dev, "of_i2c: walking child nodes\n");
> 
> -	for_each_child_of_node(adap->dev.of_node, node) {
> +	for_each_available_child_of_node(adap->dev.of_node, node) {
>  		struct i2c_board_info info = {};
>  		struct dev_archdata dev_ad = {};
>  		const __be32 *addr;


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog