From: Alexander Sverdlin <asv-uSbOeAmDUekAvxtiuMwx3w@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Jochen Friedrich <jochen-NIgtFMG+Po8@public.gmane.org>,
Jon Smirl <jonsmirl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
alexander sverdlin
<alexander.sverdlin.ext-OYasijW0DpE@public.gmane.org>
Subject: Re: [PATCH] of_i2c: Honour "status=disabled" property of device
Date: Wed, 28 Nov 2012 17:51:58 +0100 [thread overview]
Message-ID: <50B6412E.7060906@sysgo.com> (raw)
In-Reply-To: <50B638CC.6070106-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Hi!
On 11/28/2012 05:16 PM, Stephen Warren wrote:
> On 11/28/2012 07:21 AM, Alexander Sverdlin wrote:
>> of_i2c: Honour "status=disabled" property of device
>>
>> Currently of_i2c_register_devices() function registers all i2c devices,
>> independently from their status property in device tree. According to
>> "ePAPR 1.1" spec, device should only be registered if there is no
>> "status" property, or it has "ok" (or "okay") value (see
>> of_device_is_available()). In case of "platform devices",
>> of_platform_device_create_pdata() checks for "status" and ensures
>> that disabled devices are not populated. But such check for i2c buses
>> was missing until now. Fix it.
>
> Do SPI and other buses (e.g. MDIO/MDIO mux?) need a similar change?
You are right, of_register_spi_devices() and of_mdiobus_register() both have exactly the same issue.
Should it be a follow-up patch, or better to combine them to one patch?
--
Best regards,
Alexander Sverdlin.
next prev parent reply other threads:[~2012-11-28 16:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 14:21 [PATCH] of_i2c: Honour "status=disabled" property of device Alexander Sverdlin
[not found] ` <50B61DDA.5090109-uSbOeAmDUekAvxtiuMwx3w@public.gmane.org>
2012-11-28 16:16 ` Stephen Warren
[not found] ` <50B638CC.6070106-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-11-28 16:51 ` Alexander Sverdlin [this message]
[not found] ` <50B6412E.7060906-uSbOeAmDUekAvxtiuMwx3w@public.gmane.org>
2012-11-28 17:05 ` Rob Herring
2012-11-28 17:10 ` Wolfram Sang
2012-11-29 3:20 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B6412E.7060906@sysgo.com \
--to=asv-usboeamduekavxtiumwx3w@public.gmane.org \
--cc=alexander.sverdlin.ext-OYasijW0DpE@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=jochen-NIgtFMG+Po8@public.gmane.org \
--cc=jonsmirl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).