* [PATCH -next] of: export "allnodes" to fixx w1-gpio.c modular build [not found] <20121129174057.99da02b15426c76054d05592@canb.auug.org.au> @ 2012-11-29 23:43 ` Randy Dunlap 2012-11-30 9:54 ` Grant Likely 0 siblings, 1 reply; 2+ messages in thread From: Randy Dunlap @ 2012-11-29 23:43 UTC (permalink / raw) To: Grant Likely, Rob Herring Cc: Stephen Rothwell, linux-next, linux-kernel, devicetree-discuss, Ville Syrjala From: Randy Dunlap <rdunlap@infradead.org> Fix build when CONFIG_W1_MASTER_GPIO=m by exporting "allnodes". ERROR: "allnodes" [drivers/w1/masters/w1-gpio.ko] undefined! Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Ville Syrjala <syrjala@sci.fi> --- drivers/of/base.c | 1 + 1 file changed, 1 insertion(+) --- linux-next-20121129.orig/drivers/of/base.c +++ linux-next-20121129/drivers/of/base.c @@ -46,6 +46,7 @@ struct alias_prop { static LIST_HEAD(aliases_lookup); struct device_node *allnodes; +EXPORT_SYMBOL(allnodes); struct device_node *of_chosen; struct device_node *of_aliases; ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] of: export "allnodes" to fixx w1-gpio.c modular build 2012-11-29 23:43 ` [PATCH -next] of: export "allnodes" to fixx w1-gpio.c modular build Randy Dunlap @ 2012-11-30 9:54 ` Grant Likely 0 siblings, 0 replies; 2+ messages in thread From: Grant Likely @ 2012-11-30 9:54 UTC (permalink / raw) To: Randy Dunlap, Rob Herring Cc: Stephen Rothwell, linux-next, linux-kernel, devicetree-discuss, Ville Syrjala On Thu, 29 Nov 2012 15:43:08 -0800, Randy Dunlap <rdunlap@infradead.org> wrote: > From: Randy Dunlap <rdunlap@infradead.org> > > Fix build when CONFIG_W1_MASTER_GPIO=m by exporting "allnodes". > > ERROR: "allnodes" [drivers/w1/masters/w1-gpio.ko] undefined! > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Ville Syrjala <syrjala@sci.fi> > --- > drivers/of/base.c | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20121129.orig/drivers/of/base.c > +++ linux-next-20121129/drivers/of/base.c > @@ -46,6 +46,7 @@ struct alias_prop { > static LIST_HEAD(aliases_lookup); > > struct device_node *allnodes; > +EXPORT_SYMBOL(allnodes); Makes sense, but I don't like exporting such a generic name. I'm picking up the patch but renaming s/allnodes/of_allnodes/ in the process. g. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-30 9:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20121129174057.99da02b15426c76054d05592@canb.auug.org.au>
2012-11-29 23:43 ` [PATCH -next] of: export "allnodes" to fixx w1-gpio.c modular build Randy Dunlap
2012-11-30 9:54 ` Grant Likely
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).