From: Stephen Warren <swarren@wwwdotorg.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
alan@linux.intel.com, gregkh@linuxfoundation.org, jslaby@suse.cz,
rob.herring@calxeda.com, devicetree-discuss@lists.ozlabs.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] serial: tegra: add serial driver
Date: Mon, 17 Dec 2012 14:31:34 -0700 [thread overview]
Message-ID: <50CF8F36.2030309@wwwdotorg.org> (raw)
In-Reply-To: <20121217171027.6AE573E0BDD@localhost>
On 12/17/2012 10:10 AM, Grant Likely wrote:
> On Mon, 17 Dec 2012 17:40:49 +0530, Laxman Dewangan <ldewangan@nvidia.com> wrote:
>> Nvidia's Tegra has multiple uart controller which supports:
>> - APB dma based controller fifo read/write.
>> - End Of Data interrupt in incoming data to know whether end
>> of frame achieve or not.
>> - Hw controlled RTS and CTS flow control to reduce SW overhead.
>> +static int __devinit tegra_uart_probe(struct platform_device *pdev)
>> +{
>> + struct tegra_uart_port *tup;
>> + struct uart_port *u;
>> + struct tegra_uart_platform_data *pdata = pdev->dev.platform_data;
>
> Since this is a new driver, and all new board support will use device
> tree, when would this platform_data pointer get set? Can you drop the
> platform_data support code entirely?
Aren't we still supposed to support platform data so that it can
override what's in DT in order to fix up bad DTs? Or, has that
requirement been dropped. If it has, we can drop a bunch of code from a
variety of Tegra-specific drivers, I expect.
next prev parent reply other threads:[~2012-12-17 21:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 12:10 [PATCH] serial: tegra: add serial driver Laxman Dewangan
2012-12-17 15:13 ` Greg KH
2012-12-17 15:24 ` Rob Herring
2012-12-17 21:30 ` Stephen Warren
2012-12-17 17:10 ` Grant Likely
2012-12-17 21:31 ` Stephen Warren [this message]
2012-12-19 13:01 ` Grant Likely
2012-12-19 14:15 ` Laxman Dewangan
[not found] ` <50D1CC07.6070506-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-12-19 16:58 ` Stephen Warren
2012-12-20 1:09 ` Grant Likely
2012-12-17 18:23 ` Alan Cox
[not found] ` <1355746249-15347-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-12-17 21:36 ` Stephen Warren
[not found] ` <50CF9043.8030308-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-12-17 21:58 ` Mitch Bradley
[not found] ` <50CF9580.4050300-D5eQfiDGL7eakBO8gow8eQ@public.gmane.org>
2012-12-17 22:04 ` Stephen Warren
[not found] ` <50CF96D4.6010705-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-12-17 22:17 ` Mitch Bradley
2012-12-19 13:03 ` Grant Likely
2012-12-17 21:55 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CF8F36.2030309@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=alan@linux.intel.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=ldewangan@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).