devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
To: Vivek Gautam <gautam.vivek@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, kgene.kim@samsung.com,
	balbi@ti.com, thomas.abraham@linaro.org, rob.herring@calxeda.com,
	grant.likely@secretlab.ca, p.paneri@samsung.com
Subject: Re: [PATCH 2/2] ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver
Date: Wed, 19 Dec 2012 00:32:35 +0100	[thread overview]
Message-ID: <50D0FD13.5060508@gmail.com> (raw)
In-Reply-To: <1355845182-14104-3-git-send-email-gautam.vivek@samsung.com>

On 12/18/2012 04:39 PM, Vivek Gautam wrote:
> Adding base address information required for enabling
> USB 3.0 DRD phy on exynos5250 SOC.
>
> Signed-off-by: Vivek Gautam<gautam.vivek@samsung.com>
> ---
>   arch/arm/boot/dts/exynos5250.dtsi |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index bbdb2c2..07b7477 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -316,7 +316,8 @@
>
>   	usbphy@12130000 {
>   		compatible = "samsung,exynos5250-usbphy";
> -		reg =<0x12130000 0x100>;
> +		reg =<0x12130000 0x100>,
> +		<0x12100000 0x100>;

Doesn't this second memory region mean distinct PHY controller device ?
Why separate usbphy node can't/shouldn't be created for it ?

>   		samsung,usb-phyhandle =<&phy_h0&phy_h1&phy_h2>;
>   		samsung,enable-mask =<1>;
>   	};

  reply	other threads:[~2012-12-18 23:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-18 15:39 [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy Vivek Gautam
     [not found] ` <1355845182-14104-1-git-send-email-gautam.vivek-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-12-18 15:39   ` [PATCH 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver Vivek Gautam
2012-12-19  5:47     ` Vivek Gautam
2013-01-18 13:10   ` [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy Felipe Balbi
     [not found]     ` <20130118131013.GG4672-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-01-18 13:12       ` Felipe Balbi
2013-01-22  5:06         ` Kukjin Kim
2013-01-22  5:54           ` Vivek Gautam
2012-12-18 15:39 ` [PATCH 2/2] ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver Vivek Gautam
2012-12-18 23:32   ` Sylwester Nawrocki [this message]
2012-12-19  5:49     ` Vivek Gautam
2012-12-19  5:45 ` [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy Vivek Gautam
  -- strict thread matches above, loose matches on Subject: below --
2012-11-06 15:36 [PATCH 0/2] Adding USB 3.0 DRD-phy support for exynos5250 Vivek Gautam
2012-11-06 15:36 ` [PATCH 2/2] ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver Vivek Gautam
2012-11-07 18:34   ` Sylwester Nawrocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50D0FD13.5060508@gmail.com \
    --to=sylvester.nawrocki@gmail.com \
    --cc=balbi@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=gautam.vivek@samsung.com \
    --cc=grant.likely@secretlab.ca \
    --cc=kgene.kim@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=p.paneri@samsung.com \
    --cc=rob.herring@calxeda.com \
    --cc=thomas.abraham@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).