[PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy

[PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy

[Vivek Gautam]

This patch-set enables the samsung-usbphy driver on exynos5250,
which enables the support for USB2 type and USB3 type phys.
The corresponding phy driver patches are available at:
 1) https://lkml.org/lkml/2012/12/18/201
 2) https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-December/024559.html

Tested this patch-set on exynos5250 with following patch-sets for
USB 2.0 and USB 3.0:
 - https://patchwork.kernel.org/patch/1794651/
 - https://lkml.org/lkml/2012/12/18/201
 - https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-December/024559.html
 - http://comments.gmane.org/gmane.linux.usb.general/76352
 - https://lkml.org/lkml/2012/12/13/492

Vivek Gautam (2):
  ARM: Exynos5250: Enabling samsung-usbphy driver
  ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver

 arch/arm/boot/dts/exynos5250.dtsi       |   23 +++++++++++++++++++++++
 arch/arm/mach-exynos/include/mach/map.h |    1 +
 arch/arm/mach-exynos/mach-exynos5-dt.c  |    2 ++
 3 files changed, 26 insertions(+), 0 deletions(-)

-- 
1.7.6.5

[PATCH 2/2] ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver

[Vivek Gautam]

Adding base address information required for enabling
USB 3.0 DRD phy on exynos5250 SOC.

Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
---
 arch/arm/boot/dts/exynos5250.dtsi |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index bbdb2c2..07b7477 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -316,7 +316,8 @@
 
 	usbphy@12130000 {
 		compatible = "samsung,exynos5250-usbphy";
-		reg = <0x12130000 0x100>;
+		reg = <0x12130000 0x100>,
+		      <0x12100000 0x100>;
 		samsung,usb-phyhandle = <&phy_h0 &phy_h1 &phy_h2>;
 		samsung,enable-mask = <1>;
 	};
-- 
1.7.6.5

Re: [PATCH 2/2] ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver

[Sylwester Nawrocki]

On 12/18/2012 04:39 PM, Vivek Gautam wrote:
> Adding base address information required for enabling
> USB 3.0 DRD phy on exynos5250 SOC.
>
> Signed-off-by: Vivek Gautam<gautam.vivek@samsung.com>
> ---
>   arch/arm/boot/dts/exynos5250.dtsi |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index bbdb2c2..07b7477 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -316,7 +316,8 @@
>
>   	usbphy@12130000 {
>   		compatible = "samsung,exynos5250-usbphy";
> -		reg =<0x12130000 0x100>;
> +		reg =<0x12130000 0x100>,
> +		<0x12100000 0x100>;

Doesn't this second memory region mean distinct PHY controller device ?
Why separate usbphy node can't/shouldn't be created for it ?

>   		samsung,usb-phyhandle =<&phy_h0&phy_h1&phy_h2>;
>   		samsung,enable-mask =<1>;
>   	};

Re: [PATCH 2/2] ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver

[Vivek Gautam]

CC: Doug Anderson.


On Wed, Dec 19, 2012 at 5:02 AM, Sylwester Nawrocki
<sylvester.nawrocki@gmail.com> wrote:
> On 12/18/2012 04:39 PM, Vivek Gautam wrote:
>>
>> Adding base address information required for enabling
>> USB 3.0 DRD phy on exynos5250 SOC.
>>
>> Signed-off-by: Vivek Gautam<gautam.vivek@samsung.com>
>> ---
>>   arch/arm/boot/dts/exynos5250.dtsi |    3 ++-
>>   1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
>> b/arch/arm/boot/dts/exynos5250.dtsi
>> index bbdb2c2..07b7477 100644
>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>> @@ -316,7 +316,8 @@
>>
>>         usbphy@12130000 {
>>                 compatible = "samsung,exynos5250-usbphy";
>> -               reg =<0x12130000 0x100>;
>> +               reg =<0x12130000 0x100>,
>> +               <0x12100000 0x100>;
>
>
> Doesn't this second memory region mean distinct PHY controller device ?
> Why separate usbphy node can't/shouldn't be created for it ?
>
>>                 samsung,usb-phyhandle =<&phy_h0&phy_h1&phy_h2>;
>>                 samsung,enable-mask =<1>;
>>         };
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Thanks & Regards
Vivek

Re: [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy

[Vivek Gautam]

CC: Doug Anderson.


On Tue, Dec 18, 2012 at 9:09 PM, Vivek Gautam <gautam.vivek@samsung.com> wrote:
> This patch-set enables the samsung-usbphy driver on exynos5250,
> which enables the support for USB2 type and USB3 type phys.
> The corresponding phy driver patches are available at:
>  1) https://lkml.org/lkml/2012/12/18/201
>  2) https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-December/024559.html
>
> Tested this patch-set on exynos5250 with following patch-sets for
> USB 2.0 and USB 3.0:
>  - https://patchwork.kernel.org/patch/1794651/
>  - https://lkml.org/lkml/2012/12/18/201
>  - https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-December/024559.html
>  - http://comments.gmane.org/gmane.linux.usb.general/76352
>  - https://lkml.org/lkml/2012/12/13/492
>
> Vivek Gautam (2):
>   ARM: Exynos5250: Enabling samsung-usbphy driver
>   ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver
>
>  arch/arm/boot/dts/exynos5250.dtsi       |   23 +++++++++++++++++++++++
>  arch/arm/mach-exynos/include/mach/map.h |    1 +
>  arch/arm/mach-exynos/mach-exynos5-dt.c  |    2 ++
>  3 files changed, 26 insertions(+), 0 deletions(-)
>
> --
> 1.7.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Thanks & Regards
Vivek

[PATCH 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver

[Vivek Gautam]

Adding usbphy node for Exynos5250 along with the
necessary device data to be parsed.

Signed-off-by: Vivek Gautam <gautam.vivek-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
 arch/arm/boot/dts/exynos5250.dtsi       |   22 ++++++++++++++++++++++
 arch/arm/mach-exynos/include/mach/map.h |    1 +
 arch/arm/mach-exynos/mach-exynos5-dt.c  |    2 ++
 3 files changed, 25 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 581e57a..bbdb2c2 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -299,6 +299,28 @@
 		rx-dma-channel = <&pdma0 11>; /* preliminary */
 	};
 
+	phy_h0: usbdev_phyctrl@10040704 {
+		compatible = "samsung,usbdev-phyctrl";
+		samsung,phyhandle-reg = <0x10040704>;
+	};
+
+	phy_h1: usbhost_phyctrl@10040708 {
+		compatible = "samsung,usbhost-phyctrl";
+		samsung,phyhandle-reg = <0x10040708>;
+	};
+
+	phy_h2: usbhost_phycfg@10050230 {
+		compatible = "samsung,usb-phycfg";
+		samsung,phyhandle-reg = <0x10050230>;
+	};
+
+	usbphy@12130000 {
+		compatible = "samsung,exynos5250-usbphy";
+		reg = <0x12130000 0x100>;
+		samsung,usb-phyhandle = <&phy_h0 &phy_h1 &phy_h2>;
+		samsung,enable-mask = <1>;
+	};
+
 	amba {
 		#address-cells = <1>;
 		#size-cells = <1>;
diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h
index cbb2852..778348e 100644
--- a/arch/arm/mach-exynos/include/mach/map.h
+++ b/arch/arm/mach-exynos/include/mach/map.h
@@ -201,6 +201,7 @@
 #define EXYNOS4_PA_EHCI			0x12580000
 #define EXYNOS4_PA_OHCI			0x12590000
 #define EXYNOS4_PA_HSPHY		0x125B0000
+#define EXYNOS5_PA_HSPHY		0x12130000
 #define EXYNOS4_PA_MFC			0x13400000
 
 #define EXYNOS4_PA_UART			0x13800000
diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c
index 462e5ac..24e7529 100644
--- a/arch/arm/mach-exynos/mach-exynos5-dt.c
+++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
@@ -110,6 +110,8 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = {
 				"samsung-i2s.1", NULL),
 	OF_DEV_AUXDATA("samsung,samsung-i2s", 0x12D70000,
 				"samsung-i2s.2", NULL),
+	OF_DEV_AUXDATA("samsung,exynos5250-usbphy", EXYNOS5_PA_HSPHY,
+				"s3c-usbphy", NULL),
 	{},
 };
 
-- 
1.7.6.5

Re: [PATCH 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver

[Vivek Gautam]

CC: Doug Anderson.


On Tue, Dec 18, 2012 at 9:09 PM, Vivek Gautam <gautam.vivek@samsung.com> wrote:
> Adding usbphy node for Exynos5250 along with the
> necessary device data to be parsed.
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5250.dtsi       |   22 ++++++++++++++++++++++
>  arch/arm/mach-exynos/include/mach/map.h |    1 +
>  arch/arm/mach-exynos/mach-exynos5-dt.c  |    2 ++
>  3 files changed, 25 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 581e57a..bbdb2c2 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -299,6 +299,28 @@
>                 rx-dma-channel = <&pdma0 11>; /* preliminary */
>         };
>
> +       phy_h0: usbdev_phyctrl@10040704 {
> +               compatible = "samsung,usbdev-phyctrl";
> +               samsung,phyhandle-reg = <0x10040704>;
> +       };
> +
> +       phy_h1: usbhost_phyctrl@10040708 {
> +               compatible = "samsung,usbhost-phyctrl";
> +               samsung,phyhandle-reg = <0x10040708>;
> +       };
> +
> +       phy_h2: usbhost_phycfg@10050230 {
> +               compatible = "samsung,usb-phycfg";
> +               samsung,phyhandle-reg = <0x10050230>;
> +       };
> +
> +       usbphy@12130000 {
> +               compatible = "samsung,exynos5250-usbphy";
> +               reg = <0x12130000 0x100>;
> +               samsung,usb-phyhandle = <&phy_h0 &phy_h1 &phy_h2>;
> +               samsung,enable-mask = <1>;
> +       };
> +
>         amba {
>                 #address-cells = <1>;
>                 #size-cells = <1>;
> diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h
> index cbb2852..778348e 100644
> --- a/arch/arm/mach-exynos/include/mach/map.h
> +++ b/arch/arm/mach-exynos/include/mach/map.h
> @@ -201,6 +201,7 @@
>  #define EXYNOS4_PA_EHCI                        0x12580000
>  #define EXYNOS4_PA_OHCI                        0x12590000
>  #define EXYNOS4_PA_HSPHY               0x125B0000
> +#define EXYNOS5_PA_HSPHY               0x12130000
>  #define EXYNOS4_PA_MFC                 0x13400000
>
>  #define EXYNOS4_PA_UART                        0x13800000
> diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c
> index 462e5ac..24e7529 100644
> --- a/arch/arm/mach-exynos/mach-exynos5-dt.c
> +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
> @@ -110,6 +110,8 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = {
>                                 "samsung-i2s.1", NULL),
>         OF_DEV_AUXDATA("samsung,samsung-i2s", 0x12D70000,
>                                 "samsung-i2s.2", NULL),
> +       OF_DEV_AUXDATA("samsung,exynos5250-usbphy", EXYNOS5_PA_HSPHY,
> +                               "s3c-usbphy", NULL),
>         {},
>  };
>
> --
> 1.7.6.5
>
> _______________________________________________
> devicetree-discuss mailing list
> devicetree-discuss@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/devicetree-discuss



-- 
Thanks & Regards
Vivek

Re: [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy

[Felipe Balbi]

[-- Attachment #1.1: Type: text/plain, Size: 1057 bytes --]

Hi,

On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote:
> This patch-set enables the samsung-usbphy driver on exynos5250,
> which enables the support for USB2 type and USB3 type phys.
> The corresponding phy driver patches are available at:
>  1) https://lkml.org/lkml/2012/12/18/201
>  2) https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-December/024559.html
> 
> Tested this patch-set on exynos5250 with following patch-sets for
> USB 2.0 and USB 3.0:
>  - https://patchwork.kernel.org/patch/1794651/
>  - https://lkml.org/lkml/2012/12/18/201
>  - https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-December/024559.html
>  - http://comments.gmane.org/gmane.linux.usb.general/76352
>  - https://lkml.org/lkml/2012/12/13/492
> 
> Vivek Gautam (2):
>   ARM: Exynos5250: Enabling samsung-usbphy driver
>   ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver

What should I do with this series ? Is it ready to apply ? If it is,
then please resend with Kukjim's Acked-by.

cheers

-- 
balbi

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy

[Felipe Balbi]

[-- Attachment #1.1: Type: text/plain, Size: 1272 bytes --]

On Fri, Jan 18, 2013 at 03:10:13PM +0200, Felipe Balbi wrote:
> Hi,
> 
> On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote:
> > This patch-set enables the samsung-usbphy driver on exynos5250,
> > which enables the support for USB2 type and USB3 type phys.
> > The corresponding phy driver patches are available at:
> >  1) https://lkml.org/lkml/2012/12/18/201
> >  2) https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-December/024559.html
> > 
> > Tested this patch-set on exynos5250 with following patch-sets for
> > USB 2.0 and USB 3.0:
> >  - https://patchwork.kernel.org/patch/1794651/
> >  - https://lkml.org/lkml/2012/12/18/201
> >  - https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-December/024559.html
> >  - http://comments.gmane.org/gmane.linux.usb.general/76352
> >  - https://lkml.org/lkml/2012/12/13/492
> > 
> > Vivek Gautam (2):
> >   ARM: Exynos5250: Enabling samsung-usbphy driver
> >   ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver
> 
> What should I do with this series ? Is it ready to apply ? If it is,
> then please resend with Kukjim's Acked-by.

actually, now that I look again, it's all under arch/arm/, so Kukjim can
take all of those through his tree ;-)

-- 
balbi

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

RE: [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy

[Kukjin Kim]

Felipe Balbi wrote:
> 
> On Fri, Jan 18, 2013 at 03:10:13PM +0200, Felipe Balbi wrote:
> > Hi,
> >
> > On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote:
> > > This patch-set enables the samsung-usbphy driver on exynos5250,
> > > which enables the support for USB2 type and USB3 type phys.
> > > The corresponding phy driver patches are available at:
> > >  1) https://lkml.org/lkml/2012/12/18/201
> > >  2) https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-
> December/024559.html
> > >
> > > Tested this patch-set on exynos5250 with following patch-sets for
> > > USB 2.0 and USB 3.0:
> > >  - https://patchwork.kernel.org/patch/1794651/
> > >  - https://lkml.org/lkml/2012/12/18/201
> > >  - https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-
> December/024559.html
> > >  - http://comments.gmane.org/gmane.linux.usb.general/76352
> > >  - https://lkml.org/lkml/2012/12/13/492
> > >
> > > Vivek Gautam (2):
> > >   ARM: Exynos5250: Enabling samsung-usbphy driver
> > >   ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver
> >
> > What should I do with this series ? Is it ready to apply ? If it is,
> > then please resend with Kukjim's Acked-by.
> 
> actually, now that I look again, it's all under arch/arm/, so Kukjim can
> take all of those through his tree ;-)
> 
Yes, once Vivek addresses comments from Sylwester, let me pick up into
Samsung tree :-)

Thanks.

- Kukjin

Re: [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy

[Vivek Gautam]

Hi Kukjin,


On Tue, Jan 22, 2013 at 10:36 AM, Kukjin Kim <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> Felipe Balbi wrote:
>>
>> On Fri, Jan 18, 2013 at 03:10:13PM +0200, Felipe Balbi wrote:
>> > Hi,
>> >
>> > On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote:
>> > > This patch-set enables the samsung-usbphy driver on exynos5250,
>> > > which enables the support for USB2 type and USB3 type phys.
>> > > The corresponding phy driver patches are available at:
>> > >  1) https://lkml.org/lkml/2012/12/18/201
>> > >  2) https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-
>> December/024559.html
>> > >
>> > > Tested this patch-set on exynos5250 with following patch-sets for
>> > > USB 2.0 and USB 3.0:
>> > >  - https://patchwork.kernel.org/patch/1794651/
>> > >  - https://lkml.org/lkml/2012/12/18/201
>> > >  - https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-
>> December/024559.html
>> > >  - http://comments.gmane.org/gmane.linux.usb.general/76352
>> > >  - https://lkml.org/lkml/2012/12/13/492
>> > >
>> > > Vivek Gautam (2):
>> > >   ARM: Exynos5250: Enabling samsung-usbphy driver
>> > >   ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver
>> >
>> > What should I do with this series ? Is it ready to apply ? If it is,
>> > then please resend with Kukjim's Acked-by.
>>
>> actually, now that I look again, it's all under arch/arm/, so Kukjim can
>> take all of those through his tree ;-)
>>
> Yes, once Vivek addresses comments from Sylwester, let me pick up into
> Samsung tree :-)
>

Sure, i shall update this patch-series based on separate drivers for
USB 3.0 PHY controller
as posted in following patch series :
[PATCH v3 0/2] Adding USB 3.0 DRD-phy support for exynos5250



-- 
Thanks & Regards
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 0/2] Adding USB 3.0 DRD-phy support for exynos5250

[Vivek Gautam]

This patchset is based on the work for USB 2.0 host phy support
for exynos5250
https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-November/021915.html

Based on 'usb-next' branch.
Tested on smdk5250 with following patch-series:
https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-November/021923.html
http://www.spinics.net/lists/linux-usb/msg73857.html

Vivek Gautam (2):
  USB: PHY: Add support for USB 3.0 phy for exynos5250
  ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver

 arch/arm/boot/dts/exynos5250.dtsi            |    3 +-
 arch/arm/mach-exynos/include/mach/regs-pmu.h |    4 +
 arch/arm/mach-exynos/setup-usb-phy.c         |    9 +
 drivers/usb/phy/samsung-usbphy.c             |  337 ++++++++++++++++++++++++++
 include/linux/usb/samsung_usb_phy.h          |    1 +
 5 files changed, 353 insertions(+), 1 deletions(-)

-- 
1.7.6.5

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver

[Vivek Gautam]

Adding base address information and required platform data
support for enabling USB DRD phy on exynos5250 SOC.

Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
---
 arch/arm/boot/dts/exynos5250.dtsi            |    3 ++-
 arch/arm/mach-exynos/include/mach/regs-pmu.h |    4 ++++
 arch/arm/mach-exynos/setup-usb-phy.c         |    9 +++++++++
 3 files changed, 15 insertions(+), 1 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 82bf042..51693af 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -220,7 +220,8 @@
 
 	usbphy {
 		compatible = "samsung,exynos5250-usbphy";
-		reg = <0x12130000 0x100>;
+		reg = <0x12130000 0x100>,
+		      <0x12100000 0x100>;
 	};
 
 	amba {
diff --git a/arch/arm/mach-exynos/include/mach/regs-pmu.h b/arch/arm/mach-exynos/include/mach/regs-pmu.h
index d4e392b..67132b4 100644
--- a/arch/arm/mach-exynos/include/mach/regs-pmu.h
+++ b/arch/arm/mach-exynos/include/mach/regs-pmu.h
@@ -39,6 +39,10 @@
 #define S5P_HDMI_PHY_CONTROL			S5P_PMUREG(0x0700)
 #define S5P_HDMI_PHY_ENABLE			(1 << 0)
 
+/* only for EXYNOS5250*/
+#define S5P_USBDRD_PHY_CONTROL			S5P_PMUREG(0x0704)
+#define S5P_USBDRD_PHY_ENABLE			(1 << 0)
+
 #define S5P_DAC_PHY_CONTROL			S5P_PMUREG(0x070C)
 #define S5P_DAC_PHY_ENABLE			(1 << 0)
 
diff --git a/arch/arm/mach-exynos/setup-usb-phy.c b/arch/arm/mach-exynos/setup-usb-phy.c
index 6c768e0..5e46fdd 100644
--- a/arch/arm/mach-exynos/setup-usb-phy.c
+++ b/arch/arm/mach-exynos/setup-usb-phy.c
@@ -238,6 +238,15 @@ void s5p_usb_phy_pmu_isolation(int on, int type)
 			writel(readl(S5P_USBHOST_PHY_CONTROL)
 				| S5P_USBHOST_PHY_ENABLE,
 					S5P_USBHOST_PHY_CONTROL);
+	} else if (type == USB_PHY_TYPE_DRD) {
+		if (on)
+			writel(readl(S5P_USBDRD_PHY_CONTROL)
+				& ~S5P_USBDRD_PHY_ENABLE,
+					S5P_USBDRD_PHY_CONTROL);
+		else
+			writel(readl(S5P_USBDRD_PHY_CONTROL)
+				| S5P_USBDRD_PHY_ENABLE,
+					S5P_USBDRD_PHY_CONTROL);
 	} else {
 		if (on)
 			writel(readl(S5P_USBDEVICE_PHY_CONTROL)
-- 
1.7.6.5

Re: [PATCH 2/2] ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver

[Sylwester Nawrocki]

Hi Vivek,

On 11/06/2012 04:36 PM, Vivek Gautam wrote:
> Adding base address information and required platform data
> support for enabling USB DRD phy on exynos5250 SOC.
>
> Signed-off-by: Vivek Gautam<gautam.vivek@samsung.com>
> ---
>   arch/arm/boot/dts/exynos5250.dtsi            |    3 ++-
>   arch/arm/mach-exynos/include/mach/regs-pmu.h |    4 ++++
>   arch/arm/mach-exynos/setup-usb-phy.c         |    9 +++++++++
>   3 files changed, 15 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 82bf042..51693af 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -220,7 +220,8 @@
>
>   	usbphy {
>   		compatible = "samsung,exynos5250-usbphy";
> -		reg =<0x12130000 0x100>;
> +		reg =<0x12130000 0x100>,
> +		<0x12100000 0x100>;
>   	};
>
>   	amba {
> diff --git a/arch/arm/mach-exynos/include/mach/regs-pmu.h b/arch/arm/mach-exynos/include/mach/regs-pmu.h
> index d4e392b..67132b4 100644
> --- a/arch/arm/mach-exynos/include/mach/regs-pmu.h
> +++ b/arch/arm/mach-exynos/include/mach/regs-pmu.h
> @@ -39,6 +39,10 @@
>   #define S5P_HDMI_PHY_CONTROL			S5P_PMUREG(0x0700)
>   #define S5P_HDMI_PHY_ENABLE			(1<<  0)
>
> +/* only for EXYNOS5250*/
> +#define S5P_USBDRD_PHY_CONTROL			S5P_PMUREG(0x0704)
> +#define S5P_USBDRD_PHY_ENABLE			(1<<  0)

Hmm, couldn't it be added to your usbphy node above and then this register
left for the usb phy driver to do ioremap and control it directly ? Rather
than relying on the platform data callback ? I hoped this static mapping
can be dropped once there is a proper usb phy driver in place. AFAIU
arch/arm/mach-exynos/setup-usb-phy.c is supposed to be a non-dt only thing.

> +
>   #define S5P_DAC_PHY_CONTROL			S5P_PMUREG(0x070C)
>   #define S5P_DAC_PHY_ENABLE			(1<<  0)
>
> diff --git a/arch/arm/mach-exynos/setup-usb-phy.c b/arch/arm/mach-exynos/setup-usb-phy.c
> index 6c768e0..5e46fdd 100644
> --- a/arch/arm/mach-exynos/setup-usb-phy.c
> +++ b/arch/arm/mach-exynos/setup-usb-phy.c
> @@ -238,6 +238,15 @@ void s5p_usb_phy_pmu_isolation(int on, int type)
>   			writel(readl(S5P_USBHOST_PHY_CONTROL)
>   				| S5P_USBHOST_PHY_ENABLE,
>   					S5P_USBHOST_PHY_CONTROL);
> +	} else if (type == USB_PHY_TYPE_DRD) {
> +		if (on)
> +			writel(readl(S5P_USBDRD_PHY_CONTROL)
> +				&  ~S5P_USBDRD_PHY_ENABLE,
> +					S5P_USBDRD_PHY_CONTROL);

This is horrible coding style IMHO BTW. Why not just do

		u32 reg = readl(S5P_USBDRD_PHY_CONTROL);
		if (on)
			reg &= ~S5P_USBDRD_PHY_ENABLE;
		else
			reg |= ~S5P_USBDRD_PHY_ENABLE;
		writel(reg, S5P_USBDRD_PHY_CONTROL);

Or to create some read/modify/write helper ? Anyway, I suppose this whole
setup-usb-phy.c file is going to be removed, once exynos is completely dt
only.

> +		else
> +			writel(readl(S5P_USBDRD_PHY_CONTROL)
> +				| S5P_USBDRD_PHY_ENABLE,
> +					S5P_USBDRD_PHY_CONTROL);
>   	} else {
>   		if (on)
>   			writel(readl(S5P_USBDEVICE_PHY_CONTROL)

--

Thanks,
Sylwester