From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [RFC 3/5] ARM: CTI: Convert CTI helpers to AMBA bus driver Date: Wed, 2 Jan 2013 13:13:47 -0600 Message-ID: <50E486EB.8030506@ti.com> References: <1355348588-22318-1-git-send-email-jon-hunter@ti.com> <1355348588-22318-4-git-send-email-jon-hunter@ti.com> <20121221222703.GB2658@pratikp-linux.qualcomm.com> <20121221223558.GC2658@pratikp-linux.qualcomm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20121221223558.GC2658@pratikp-linux.qualcomm.com> Sender: linux-omap-owner@vger.kernel.org To: Pratik Patel Cc: Paul Walmsley , Russell King , device-tree , Will Deacon , Rob Herring , Grant Likely , linux-arm , linux-omap , Ming Lei , Linus Walleij List-Id: devicetree@vger.kernel.org On 12/21/2012 04:35 PM, Pratik Patel wrote: > On Fri, Dec 21, 2012 at 02:27:03PM -0800, Pratik Patel wrote: >> On Wed, Dec 12, 2012 at 03:43:06PM -0600, Jon Hunter wrote: >>> + >>> +/** >>> + * cti_irq_ack - acknowledges the CTI trigger output >>> + * @cti: CTI instance >>> + * >>> + * Acknowledges the CTI trigger output by writting to the appropriate >>> + * bit in the CTI interrupt acknowledge register. >>> + */ >>> +int cti_irq_ack(struct cti *cti) >>> +{ >>> + u32 v; >>> + >>> + if (!cti || !cti->enabled) >>> + return -EINVAL; >>> + >>> + v = cti_readl(cti, CTIINTACK); >> >> Just curious if CTIINTACK is a read-write register? This is a >> read-only for us. >> > Mistyped - its a write-only for us You are right. Looking at the ARM documentation this is a write-only register. I had copied this function from the original helpers but had not checked if this was readable. I will correct this. Cheers Jon