From: Jon Hunter <jon-hunter@ti.com>
To: Pratik Patel <pratikp@codeaurora.org>
Cc: Russell King <linux@arm.linux.org.uk>,
Will Deacon <will.deacon@arm.com>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Paul Walmsley <paul@pwsan.com>,
device-tree <devicetree-discuss@lists.ozlabs.org>,
Ming Lei <ming.lei@canonical.com>,
linux-omap <linux-omap@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-arm <linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC 3/5] ARM: CTI: Convert CTI helpers to AMBA bus driver
Date: Wed, 2 Jan 2013 13:23:32 -0600 [thread overview]
Message-ID: <50E48934.6070201@ti.com> (raw)
In-Reply-To: <20121221222703.GB2658@pratikp-linux.qualcomm.com>
On 12/21/2012 04:27 PM, Pratik Patel wrote:
> On Wed, Dec 12, 2012 at 03:43:06PM -0600, Jon Hunter wrote:
>> +
>> +/**
>> + * cti_irq_ack - acknowledges the CTI trigger output
>> + * @cti: CTI instance
>> + *
>> + * Acknowledges the CTI trigger output by writting to the appropriate
>> + * bit in the CTI interrupt acknowledge register.
>> + */
>> +int cti_irq_ack(struct cti *cti)
>> +{
>> + u32 v;
>> +
>> + if (!cti || !cti->enabled)
>> + return -EINVAL;
>> +
>> + v = cti_readl(cti, CTIINTACK);
>
> Just curious if CTIINTACK is a read-write register? This is a
> read-only for us.
>
>> + v |= BIT(cti->trig_out);
>> + cti_writel(v, cti, CTIINTACK);
>> +
>> + return 0;
>> +}
>> +
>> +
>> +static int cti_probe(struct amba_device *dev, const struct amba_id *id)
>> +{
>> + struct cti *cti;
>> + struct device_node *np = dev->dev.of_node;
>> + int rc;
>> +
>> + if (!np) {
>> + dev_err(&dev->dev, "device-tree not found!\n");
>> + return -ENODEV;
>> + }
>> +
>> + cti = devm_kzalloc(&dev->dev, sizeof(struct cti), GFP_KERNEL);
>> + if (!cti) {
>> + dev_err(&dev->dev, "memory allocation failed!\n");
>> + return -ENOMEM;
>> + }
>> +
>> + rc = of_property_read_string_index(np, "arm,cti-name", 0, &cti->name);
>> + if (rc) {
>> + dev_err(&dev->dev, "no name found for CTI!\n");
>> + return rc;
>> + }
>
> Shouldn't the CTI driver have some kind of clock management that
> it does for itself?
It does by using runtime PM. If you look at the cti_get/put functions,
you will see calls to pm_runtime_get/put. These calls will enable the
AMBA apb-clock. If you need to enable additional clocks then you could
register pm runtime resume/idle call backs to do this.
Cheers
Jon
next prev parent reply other threads:[~2013-01-02 19:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 21:43 [RFC 0/5] ARM: Add Cross Trigger Interface driver Jon Hunter
[not found] ` <1355348588-22318-1-git-send-email-jon-hunter-l0cyMroinI0@public.gmane.org>
2012-12-12 21:43 ` [RFC 1/5] ARM: CORESIGHT: Add generic lock/unlock helpers Jon Hunter
[not found] ` <1355348588-22318-2-git-send-email-jon-hunter-l0cyMroinI0@public.gmane.org>
2012-12-13 14:58 ` Will Deacon
[not found] ` <20121213145803.GL26540-MRww78TxoiP5vMa5CHWGZ34zcgK1vI+I0E9HWUfgJXw@public.gmane.org>
2012-12-13 19:18 ` Jon Hunter
2012-12-13 19:36 ` Jean Pihet
2012-12-12 21:43 ` [RFC 4/5] ARM: dts: OMAP4: Add CTI nodes Jon Hunter
2012-12-12 21:43 ` [RFC 2/5] ARM: dts: Add Cross Trigger Interface binding Jon Hunter
2012-12-12 22:12 ` Rob Herring
2012-12-12 23:23 ` Jon Hunter
2012-12-14 19:53 ` Rob Herring
2012-12-13 17:41 ` Will Deacon
2012-12-13 19:21 ` Jon Hunter
2012-12-17 16:20 ` Mark Rutland
2012-12-17 16:30 ` Jon Hunter
2012-12-12 21:43 ` [RFC 3/5] ARM: CTI: Convert CTI helpers to AMBA bus driver Jon Hunter
2012-12-13 15:08 ` Will Deacon
[not found] ` <20121213150826.GM26540-MRww78TxoiP5vMa5CHWGZ34zcgK1vI+I0E9HWUfgJXw@public.gmane.org>
2012-12-13 19:35 ` Jon Hunter
2012-12-21 22:27 ` Pratik Patel
2012-12-21 22:35 ` Pratik Patel
2013-01-02 19:13 ` Jon Hunter
2013-01-02 19:23 ` Jon Hunter [this message]
2013-01-03 18:47 ` Pratik Patel
2012-12-12 21:43 ` [RFC 5/5] ARM: OMAP4: Add AMBA APB Clock Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E48934.6070201@ti.com \
--to=jon-hunter@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=ming.lei@canonical.com \
--cc=paul@pwsan.com \
--cc=pratikp@codeaurora.org \
--cc=rob.herring@calxeda.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).