From: Kumar Gala <galak@codeaurora.org>
To: Mugunthan V N <mugunthanvnm@ti.com>
Cc: balbi@ti.com, bigeasy@linutronix.de, bcousson@baylibre.com,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/1] arm: dts: am33xx: correcting dt node unit address for usb
Date: Fri, 30 Aug 2013 14:10:38 -0500 [thread overview]
Message-ID: <50F5779C-87B6-43C2-81A8-C72A0614464F@codeaurora.org> (raw)
In-Reply-To: <1377885140-3529-1-git-send-email-mugunthanvnm@ti.com>
On Aug 30, 2013, at 12:52 PM, Mugunthan V N wrote:
> DT node's unit address should be its own register offset address to make it a
> unique across the system. This patch corrects the incorrect USB entries with
> correct register offset for unit address.
>
> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Cc: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> ---
> arch/arm/boot/dts/am33xx.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index f9c5da9..e9b6775 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -346,7 +346,7 @@
> ti,hwmods = "usb_otg_hs";
> status = "disabled";
>
> - ctrl_mod: control@44e10000 {
> + ctrl_mod: control@44e10620 {
> compatible = "ti,am335x-usb-ctrl-module";
> reg = <0x44e10620 0x10
> 0x44e10648 0x4>;
> @@ -449,7 +449,7 @@
> "tx14", "tx15";
> };
>
> - cppi41dma: dma-controller@07402000 {
> + cppi41dma: dma-controller@47402000 {
Why isn't the unit address 47400000 ?
> compatible = "ti,am3359-cppi41";
> reg = <0x47400000 0x1000
> 0x47402000 0x1000
> --
> 1.8.4
- k
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2013-08-30 19:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 17:52 [PATCH 1/1] arm: dts: am33xx: correcting dt node unit address for usb Mugunthan V N
2013-08-30 19:10 ` Kumar Gala [this message]
[not found] ` <50F5779C-87B6-43C2-81A8-C72A0614464F-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2013-08-31 7:39 ` Mugunthan V N
2013-08-31 17:42 ` Sergei Shtylyov
2013-08-31 18:29 ` Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F5779C-87B6-43C2-81A8-C72A0614464F@codeaurora.org \
--to=galak@codeaurora.org \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=bigeasy@linutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).