From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 1/7] dt: describe base reset signal binding Date: Wed, 16 Jan 2013 15:06:00 -0700 Message-ID: <50F72448.8070807@wwwdotorg.org> References: <1358352787-15441-1-git-send-email-p.zabel@pengutronix.de> <1358352787-15441-2-git-send-email-p.zabel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1358352787-15441-2-git-send-email-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Philipp Zabel Cc: Marek Vasut , Fabio Estevam , Mike Turquette , Sascha Hauer , kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, Stephen Warren , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 01/16/2013 09:13 AM, Philipp Zabel wrote: > From: Stephen Warren > > This binding is intended to represent the hardware reset signals present > internally in most IC (SoC, FPGA, ...) designs. > > Such a binding would allow the creation of a "reset subsystem", which > could replace APIs such as the following Tegra-specific API: > > void tegra_periph_reset_deassert(struct clk *c); > void tegra_periph_reset_assert(struct clk *c); > > (Note that at present, Tegra couples reset assertion with the clock for > the affected peripheral module. However, reset and clocking are two > separate, yet admittedly related, concepts). > > Signed-off-by: Stephen Warren You probably want to update the patch description; it was somewhat appropriate when I sent the patch as an RFC to see what people thought about the idea, but now you're actually providing the whole thing a more specific description would be better. Your S-o-b line should be present in all patches you send; add it after mine. See Documentation/SubmittingPatches section "Sign your work" item (c) (or perhaps (b) if you modified it).