devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
	Pritesh Raithatha <praithatha@nvidia.com>,
	"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
	"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
	"devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 1/2] pinctrl: tegra: add support for rcv-sel and drive type
Date: Thu, 17 Jan 2013 14:06:17 +0530	[thread overview]
Message-ID: <50F7B801.4020704@nvidia.com> (raw)
In-Reply-To: <CACRpkdYe0MPC=jiOgzd0zRkiAFas21O80MiR8dp9UdmwptDfmw@mail.gmail.com>

On Thursday 17 January 2013 02:00 PM, Linus Walleij wrote:
> On Sat, Jan 5, 2013 at 1:02 PM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
>
>> From: Pritesh Raithatha <praithatha@nvidia.com>
>>
>> NVIDIA's Tegra114 added two more configuration parameter in pinmux i.e.
>> rcv-sel and drive type.
>>
>> rcv-sel: Select between High and Normal VIL/VIH receivers.
>>          RCVR_SEL=1: High VIL/VIH
>>          RCVR_SEL=0: Normal VIL/VIH
>>
>> drv_type: Ouptput drive type:
>>          33-50 ohm driver: 0x1
>>          66-100ohm driver: 0x0
>>
>> Add support of these parameters to be configure from DTS file.
>>
>> Tegra20 and Tegra30 does not support this configuration and hence initialize their
>> pinmux structure with reg = -1.
>>
>> Originally written by Pritesh Raithatha.
>> Changes by ldewangan:
>>          - remove drvtype_width as it is always 2.
>>          - Better describe the change.
>>
>> Signed-off-by: Pritesh Raithatha <praithatha@nvidia.com>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Stephen, can you look at this patch?
>
> Authors: you need Stephen's ACK on this.


Stephen have already given his reviewed by on thi series and I posted V2 
version of taking care his comment.
Stephen's comment was in
Re: [PATCH 2/2] pinctrl: tegra114: add pinctrl driver for NVIDIA's 
Tegra114 SoC


Can you please review the v2 version of this series?


Thanks,
Laxman

  reply	other threads:[~2013-01-17  8:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-05 12:02 [PATCH 1/2] pinctrl: tegra: add support for rcv-sel and drive type Laxman Dewangan
     [not found] ` <1357387375-25919-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-05 12:02   ` [PATCH 2/2] pinctrl: tegra114: add pinctrl driver for NVIDIA's Tegra114 SoC Laxman Dewangan
     [not found]     ` <1357387375-25919-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-07 16:58       ` Stephen Warren
2013-01-17  8:30 ` [PATCH 1/2] pinctrl: tegra: add support for rcv-sel and drive type Linus Walleij
2013-01-17  8:36   ` Laxman Dewangan [this message]
     [not found]     ` <50F7B801.4020704-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-17  9:58       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F7B801.4020704@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linus.walleij@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=praithatha@nvidia.com \
    --cc=rob.herring@calxeda.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).