From: Rob Herring <robherring2@gmail.com>
To: Cong Ding <dinggnu@gmail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: dma.c: fix memory leakage
Date: Sun, 20 Jan 2013 16:24:49 -0600 [thread overview]
Message-ID: <50FC6EB1.4050704@gmail.com> (raw)
In-Reply-To: <1358600805-20193-1-git-send-email-dinggnu@gmail.com>
On 01/19/2013 07:06 AM, Cong Ding wrote:
> The memory allocated to ofdma might be a leakage when error occurs.
>
> Signed-off-by: Cong Ding <dinggnu@gmail.com>
You need to send this to whomever is working on DMA bindings.
Rob
> ---
> drivers/of/dma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/of/dma.c b/drivers/of/dma.c
> index 59631b2..583e50e3 100644
> --- a/drivers/of/dma.c
> +++ b/drivers/of/dma.c
> @@ -107,6 +107,7 @@ int of_dma_controller_register(struct device_node *np,
> if (!nbcells) {
> pr_err("%s: #dma-cells property is missing or invalid\n",
> __func__);
> + kfree(ofdma);
> return -EINVAL;
> }
>
>
next prev parent reply other threads:[~2013-01-20 22:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-19 13:06 [PATCH] of: dma.c: fix memory leakage Cong Ding
2013-01-20 22:24 ` Rob Herring [this message]
2013-01-22 10:10 ` Cong Ding
2013-02-12 17:40 ` Vinod Koul
2013-02-13 11:26 ` Cong Ding
2013-02-14 4:42 ` Vinod Koul
2013-02-14 10:16 ` [PATCH v2] dma: of-dma.c: " Cong Ding
[not found] ` <20130214101610.GA29017-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-02-14 13:42 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FC6EB1.4050704@gmail.com \
--to=robherring2@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dinggnu@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).