From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AA32C4332F for ; Mon, 11 Apr 2022 11:38:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232426AbiDKLlB (ORCPT ); Mon, 11 Apr 2022 07:41:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245558AbiDKLk6 (ORCPT ); Mon, 11 Apr 2022 07:40:58 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AF5C45AC9 for ; Mon, 11 Apr 2022 04:38:44 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id l7so24811309ejn.2 for ; Mon, 11 Apr 2022 04:38:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=2WZi02KGSxWTDOytghirv9WvF6kDbKHRt4IaYFgOoO0=; b=U4GXJiDRmHt1bqW4x998No2cKXzPTUXZgJdIOCYJpo1QImMW3dVp46ceiqpZW99d+1 m/Z0eTaFvQpBlYDMpTjMmYPpK6ggi8t+kLWEcwLpn0zzFGhx5Wpy8V0hxHgBwZTDVZZb 0eeXz7P7N95HKev3TZQKioZsZOq8ln2COWWTyQGliCAFADddSd+qXK0rWE8VYJQMXotF MLQDCbbZ1lYgyvCZ0RebEVLySV/JxBFbS75Yt02bonON78w+YAFA8kknJnPV7bufZ3fL RfKhYMCXLUWKvdjllZD9XP0llh4fkP2Z34QDLean86/axiTY9rybX4GOklYPPnQS34PA calA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=2WZi02KGSxWTDOytghirv9WvF6kDbKHRt4IaYFgOoO0=; b=m+mhzxH6ibk2ksKEJJ5irRkvMFZce68OSvM6rx0Qq0ciB/L/BzMUlSssCFm4EdF6zE Xvd1dfFrFPj51T+mF4tFe3SvWhFeCyAue68m1xMIFihr+g0ud0pMHyTyAsljgCsUVb3j zDH3b91LB7WMOov5sNf1hSJHdHuoJIvr1+9/lXleDIoebUXMEHQLB0vOyyX0mexmSQF2 T1wBwRRi/5b22OddI7kO7xBjWVIGE+BsphBKyX3Hc6zhw6pep8m7pXfqvhyFUL0EX6AQ auHtQRR5kG3/5aphr7l6Obo1jcGEZC55ZjxRqRyQUe4UN4BMM+eeI8LRAQpu76ZVHIMt HMuQ== X-Gm-Message-State: AOAM533E0urM9cQo0YkBAxY0vkH6QRWS/uRD7wiFK2rLhpOaZ2j+nxwY kqOZWH0BBeRewi1ax27chPJgNg== X-Google-Smtp-Source: ABdhPJz+mkumgARH9hMHncsnKm9xsZWueFxOttDZlUJ+QgYKfLL1kW2o5ag0mAr1aD1zbT3NeO+rLw== X-Received: by 2002:a17:907:724c:b0:6e8:59c1:914c with SMTP id ds12-20020a170907724c00b006e859c1914cmr13259814ejc.172.1649677122864; Mon, 11 Apr 2022 04:38:42 -0700 (PDT) Received: from [192.168.0.191] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id j23-20020a1709064b5700b006e87ae0c111sm2318025ejv.123.2022.04.11.04.38.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Apr 2022 04:38:42 -0700 (PDT) Message-ID: <50defa36-3d91-80ea-e303-abaade1c1f7e@linaro.org> Date: Mon, 11 Apr 2022 13:38:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 6/6] dt-bindings: dma: Convert Qualcomm BAM DMA binding to json format Content-Language: en-US To: Kuldeep Singh Cc: Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Vinod Koul , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org References: <20220410175056.79330-1-singh.kuldeep87k@gmail.com> <20220410175056.79330-7-singh.kuldeep87k@gmail.com> <14ecb746-56f0-2d3b-2f93-1af9407de4b7@linaro.org> <20220411105810.GB33220@9a2d8922b8f1> From: Krzysztof Kozlowski In-Reply-To: <20220411105810.GB33220@9a2d8922b8f1> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/04/2022 12:58, Kuldeep Singh wrote: >> This is something new and it seems only one SoC defines it (not even one >> BAM version). I wonder whether this is actually correct or this >> particular version of BAM is slightly different. Maybe someone could >> clarify it, but if no - looks ok. > > Yes, sdm845.dtsi uses 4 entries and rest 1. Yes, I know. This does not solve my wonder. > >> >>> + >>> + num-channels: >>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> + description: >>> + Indicates supported number of DMA channels in a remotely controlled bam. >>> + >>> + qcom,controlled-remotely: >>> + $ref: /schemas/types.yaml#/definitions/flag >> >> type: boolean > > Boolean comes under flag in types.yaml > > definitions: > flag: > oneOf: > - type: boolean > const: true > - type: 'null' > > I have seen other boolean properties(spi-cpol, spi-cpha and bunch of > others) using type flag. I think we should keep flag here. type:boolean is just shorter and example-schema recommends it. If you want to base on something (as a template, pattern) then the example-schema is the source, the preferred one. >>> +required: >>> + - compatible >>> + - "#dma-cells" >>> + - interrupts >>> + - reg >> >> clocks, clock-names, qcom-ee - these are required according to old bindings. > > I missed qcom,ee. Will add in v3. > > For clocks and clock-names , there are two platforms(msm8996.dtsi, > sdm845.dtsi) where these properties are missing. And I don't want to add > some random values. Shall I skip them here? and let board owners add > them later. These are required, so the SoC DTSI should be fixed. Not with random clocks but something proper. :) Best regards, Krzysztof