From: Andrew Lunn <andrew@lunn.ch>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>,
"parthiban.veerasooran@microchip.com"
<parthiban.veerasooran@microchip.com>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net 2/2] dt-bindings: net: updated interrupt type to be active low, level triggered
Date: Fri, 15 May 2026 21:06:08 +0200 [thread overview]
Message-ID: <50e77863-4445-406a-a535-eb620d6fc1b2@lunn.ch> (raw)
In-Reply-To: <ab821805-49dd-4b55-a77d-0f25e0247bff@kernel.org>
On Fri, May 15, 2026 at 06:15:50PM +0200, Krzysztof Kozlowski wrote:
> On 15/05/2026 18:13, Selvamani Rajagopal wrote:
> > According to OPEN Alliance 10BASE-T1x MACPHY Serial Interface (TC6)
> > specification, interrupt type is active low, level triggered interrupt.
> >
> > Fixes: ac49b950bea9 ("dt-bindings: net: add Microchip's LAN865X 10BASE-T1S MACPHY")
>
> Drop, there is no bug here. That is only an example. Otherwise explain
> how does this bug affect anything.
There is a tendency for DT developers to just copy/paste the example,
and not really engage brain. So if the example is wrong, the .dts file
will be wrong.
The thing about edge interrupts when level should be used is that they
mostly work. So quick smoke testing is not going to see any problems,
it is only when some condition comes along which causes two interrupts
in quick succession will the interface grind to a halt due to a missed
interrupt.
So i think it is a useful fix to have in stable.
Andrew
prev parent reply other threads:[~2026-05-15 19:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 16:13 [PATCH net 2/2] dt-bindings: net: updated interrupt type to be active low, level triggered Selvamani Rajagopal
2026-05-15 16:15 ` Krzysztof Kozlowski
2026-05-15 16:40 ` Andrew Lunn
2026-05-15 16:44 ` Selvamani Rajagopal
2026-05-15 19:06 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50e77863-4445-406a-a535-eb620d6fc1b2@lunn.ch \
--to=andrew@lunn.ch \
--cc=Selvamani.Rajagopal@onsemi.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parthiban.veerasooran@microchip.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox