Re: [PATCH 1/4] ARM: dts: add support for hdmi to exynos4

[Sylwester Nawrocki <sylvester.nawrocki@gmail.com>]

On 01/25/2013 11:39 AM, Rahul Sharma wrote:
> Signed-off-by: Rahul Sharma<rahul.sharma@samsung.com>

Please provide proper commit text.

> Conflicts:
> 	arch/arm/mach-exynos/mach-exynos4-dt.c

And make sure things like this are removed when submitting patches.

> ---
>   arch/arm/boot/dts/exynos4.dtsi         | 7 +++++++
>   arch/arm/mach-exynos/mach-exynos4-dt.c | 2 ++
>   2 files changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index e1347fc..6c2c79d 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -289,4 +289,11 @@
>   			interrupts =<0 34 0>;
>   		};
>   	};
> +
> +	hdmi {
> +		compatible = "samsung,exynos4-hdmi14";

What "-hdmi14" signifies here ? And to which Exynos4 SoC revisions this
compatible property is supposed to apply ?

> +		reg =<0x12D00000 0x70000>;
> +		interrupts =<0 95 0>;
> +		hpd-gpio =<&gpx3 7 0xf 1 3>;
> +	};

New bindings need to be documented in Documentation/devicetree/bindings/.

--

Thanks,
Sylwester