From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH 1/4] ARM: dts: add support for hdmi to exynos4 Date: Sun, 27 Jan 2013 21:54:26 +0100 Message-ID: <51059402.2030405@gmail.com> References: <1359110384-28402-1-git-send-email-rahul.sharma@samsung.com> <1359110384-28402-2-git-send-email-rahul.sharma@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1359110384-28402-2-git-send-email-rahul.sharma@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Rahul Sharma Cc: linux-samsung-soc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, kgene.kim@samsung.com, inki.dae@samsung.com, joshi@samsung.com, r.sh.open@gmail.com List-Id: devicetree@vger.kernel.org On 01/25/2013 11:39 AM, Rahul Sharma wrote: > Signed-off-by: Rahul Sharma Please provide proper commit text. > Conflicts: > arch/arm/mach-exynos/mach-exynos4-dt.c And make sure things like this are removed when submitting patches. > --- > arch/arm/boot/dts/exynos4.dtsi | 7 +++++++ > arch/arm/mach-exynos/mach-exynos4-dt.c | 2 ++ > 2 files changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi > index e1347fc..6c2c79d 100644 > --- a/arch/arm/boot/dts/exynos4.dtsi > +++ b/arch/arm/boot/dts/exynos4.dtsi > @@ -289,4 +289,11 @@ > interrupts =<0 34 0>; > }; > }; > + > + hdmi { > + compatible = "samsung,exynos4-hdmi14"; What "-hdmi14" signifies here ? And to which Exynos4 SoC revisions this compatible property is supposed to apply ? > + reg =<0x12D00000 0x70000>; > + interrupts =<0 95 0>; > + hpd-gpio =<&gpx3 7 0xf 1 3>; > + }; New bindings need to be documented in Documentation/devicetree/bindings/. -- Thanks, Sylwester