From: Jerry Van Baren <vanbaren-He//nVnquyzQT0dZR+AlfA@public.gmane.org>
To: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Cc: Devicetree Discuss
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
Subject: Re: [PATCH] Move the fdt*_t type definitions to fdt.h
Date: Mon, 28 Jan 2013 08:29:03 -0500 [thread overview]
Message-ID: <51067D1F.1000306@cideas.com> (raw)
In-Reply-To: <20130128045233.GA4107-W9XWwYn+TF0XU02nzanrWNbf9cGiqdzd@public.gmane.org>
On 01/27/2013 11:52 PM, David Gibson wrote:
> On Sun, Jan 27, 2013 at 09:44:37PM -0500, Gerald Van Baren wrote:
>> Arguably they belong there since they are fundamental to the fdt.
>> As a side effect, I had to flip the order of #includes of fdt.h and
>> libfdt_env.h in libfdt.h since libfdt_env.h needs the fdt*_t definitions.
>>
>> Signed-off-by: Gerald Van Baren <gvb-LFPmMGy0VdYAvxtiuMwx3w@public.gmane.org>
>> ---
>>
>> I'm not sure I like this, but submit it for your consideration. If, for
>> some reason, libfdt_env.h needed to (re)define something in fdt.h, it
>> would be unable to do so. :-/
>
> Sorry, nack on this one. fdt.h is supposed to be as independent as we
> can make it from the environment in which its being compiled. That
> means I don't want it to include *any* system headers, even stdint.h.
No problem, it didn't feel right to me either. Thank you for your
consideration. :-)
Best regards,
gvb
prev parent reply other threads:[~2013-01-28 13:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 2:44 [PATCH] Move the fdt*_t type definitions to fdt.h Gerald Van Baren
[not found] ` <5105E615.30102-He//nVnquyzQT0dZR+AlfA@public.gmane.org>
2013-01-28 4:52 ` David Gibson
[not found] ` <20130128045233.GA4107-W9XWwYn+TF0XU02nzanrWNbf9cGiqdzd@public.gmane.org>
2013-01-28 13:29 ` Jerry Van Baren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51067D1F.1000306@cideas.com \
--to=vanbaren-he//nvnquyzqt0dzr+alfa@public.gmane.org \
--cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).