From: Stephen Warren <swarren@wwwdotorg.org>
To: Thomas Abraham <thomas.abraham@linaro.org>
Cc: devicetree-discuss@lists.ozlabs.org,
linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
swarren@nvidia.com, sylvester.nawrocki@gmail.com,
chaos.youn@samsung.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 4/7] ARM: Exynos: allow dt based discovery of mct controller using clocksource_of_init
Date: Mon, 28 Jan 2013 13:57:41 -0700 [thread overview]
Message-ID: <5106E645.70807@wwwdotorg.org> (raw)
In-Reply-To: <1358762542-19008-5-git-send-email-thomas.abraham@linaro.org>
On 01/21/2013 03:02 AM, Thomas Abraham wrote:
> Add entries to __clksrc_of_table so that Exynos MCT controller is discoverable
> using call to clocksource_of_init. With this change, it would be appropriate to
> rename the function 'exynos4_timer_init' as 'mct_init' since it aptly describes
> this function. Additionally, the 'init_time' callback of all machine descriptors
> for exynos platforms that were previously set to 'exynos4_timer_init' are now
> set to either 'mct_init' or 'clocksource_of_init'.
> diff --git a/arch/arm/mach-exynos/mct.c b/arch/arm/mach-exynos/mct.c
> +#ifdef CONFIG_CLKSRC_OF
> +CLOCKSOURCE_OF_DECLARE(exynos4210, "samsung,exynos4210-mct", mct_init)
> +CLOCKSOURCE_OF_DECLARE(exynos4412, "samsung,exynos4412-mct", mct_init)
> +#endif
I suggested in another review (IIRC for a different SoC) that
CLOCKSOURCE_OF_DECLARE() should always be declared so you don't need
that ifdef. Would you care to send a patch to add to arm-soc's
timer/cleanup branch to do that? If not, let me know and I can.
next prev parent reply other threads:[~2013-01-28 20:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 10:02 [PATCH v4 0/7] ARM: Exynos: Enable device tree support for MCT controller Thomas Abraham
2013-01-21 10:02 ` [PATCH v4 1/7] ARM: Exynos: add a register base address variable in mct controller driver Thomas Abraham
2013-01-21 10:02 ` [PATCH v4 2/7] ARM: Exynos: prepare an array of MCT interrupt numbers and use it Thomas Abraham
2013-01-21 10:02 ` [PATCH v4 3/7] ARM: Exynos: add device tree support for MCT controller driver Thomas Abraham
2013-01-21 13:46 ` Mark Rutland
2013-01-21 18:34 ` Thomas Abraham
2013-01-28 20:59 ` Stephen Warren
2013-01-21 10:02 ` [PATCH v4 4/7] ARM: Exynos: allow dt based discovery of mct controller using clocksource_of_init Thomas Abraham
2013-01-28 20:57 ` Stephen Warren [this message]
2013-01-30 17:50 ` Stephen Warren
2013-01-21 10:02 ` [PATCH v4 5/7] ARM: dts: add mct device tree node for all supported Exynos SoC's Thomas Abraham
2013-01-21 10:02 ` [PATCH v4 6/7] ARM: Exynos: remove static io-remapping of mct registers for Exynos5 Thomas Abraham
2013-01-21 10:02 ` [PATCH v4 7/7] ARM: Exynos: move mct driver to drivers/clocksource Thomas Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5106E645.70807@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=chaos.youn@samsung.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=swarren@nvidia.com \
--cc=sylvester.nawrocki@gmail.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).