[PATCH V2] ARM: davinci: da850: add RTC DT entries

[PATCH V2] ARM: davinci: da850: add RTC DT entries

[Mrugesh Katepallewar]

Add RTC DT entries in da850 dts file.

Signed-off-by: Mrugesh Katepallewar <mrugesh.mk@ti.com>
---
Applies on top of v3.8-rc4 of linus tree.

This patch is depending on 
"ARM: davinci: da850: add interrupt-parent property in soc node"
https://patchwork.kernel.org/patch/2044101/

Tested on da850-evm device.

Test Procedure:
date 2013.01.28-10:00:00 (usage: date[YYYY.]MM.DD-hh:mm[:ss])
hwclock -w
reset board and check system time.

Changes Since V1:
Remove interrupt-parent property from RTC node.
Change RTC node name in dts and dtsi file.

:100644 100644 37dc5a3... af4b7cc... M	arch/arm/boot/dts/da850-evm.dts
:100644 100644 640ab75... 90be701... M	arch/arm/boot/dts/da850.dtsi
 arch/arm/boot/dts/da850-evm.dts |    3 +++
 arch/arm/boot/dts/da850.dtsi    |    7 +++++++
 2 files changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
index 37dc5a3..af4b7cc 100644
--- a/arch/arm/boot/dts/da850-evm.dts
+++ b/arch/arm/boot/dts/da850-evm.dts
@@ -24,5 +24,8 @@
 		serial2: serial@1d0d000 {
 			status = "okay";
 		};
+		rtc0: rtc@1c23000 {
+			status = "okay";
+		};
 	};
 };
diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
index 640ab75..90be701 100644
--- a/arch/arm/boot/dts/da850.dtsi
+++ b/arch/arm/boot/dts/da850.dtsi
@@ -56,5 +56,12 @@
 			interrupt-parent = <&intc>;
 			status = "disabled";
 		};
+		rtc0: rtc@1c23000 {
+			compatible = "ti,da830-rtc";
+			reg = <0x23000 0x1000>;
+			interrupts = <19
+				      19>;
+			status = "disabled";
+		};
 	};
 };
-- 
1.7.9.5

Re: [PATCH V2] ARM: davinci: da850: add RTC DT entries

[Sekhar Nori]

Hi Mrugesh,

On 1/28/2013 1:17 PM, Mrugesh Katepallewar wrote:
> Add RTC DT entries in da850 dts file.
> 
> Signed-off-by: Mrugesh Katepallewar <mrugesh.mk@ti.com>
> ---
> Applies on top of v3.8-rc4 of linus tree.
> 
> This patch is depending on 
> "ARM: davinci: da850: add interrupt-parent property in soc node"
> https://patchwork.kernel.org/patch/2044101/

> Tested on da850-evm device.
> 
> Test Procedure:
> date 2013.01.28-10:00:00 (usage: date[YYYY.]MM.DD-hh:mm[:ss])
> hwclock -w
> reset board and check system time.

Queuing this for v3.9. The testing information above is useful and
should be part of the changelog. I moved it there while committing.

It will be nice to check the alarm functionality as well. Can you check
that and let me know that works as well?

Thanks,
Sekhar

RE: [PATCH V2] ARM: davinci: da850: add RTC DT entries

[Katepallewar, Mrugesh]

On Mon, Jan 28, 2013 at 21:32:13, Nori, Sekhar wrote:
> Hi Mrugesh,
> 
> On 1/28/2013 1:17 PM, Mrugesh Katepallewar wrote:
> > Add RTC DT entries in da850 dts file.
> > 
> > Signed-off-by: Mrugesh Katepallewar <mrugesh.mk@ti.com>
> > ---
> > Applies on top of v3.8-rc4 of linus tree.
> > 
> > This patch is depending on
> > "ARM: davinci: da850: add interrupt-parent property in soc node"
> > https://patchwork.kernel.org/patch/2044101/
> 
> > Tested on da850-evm device.
> > 
> > Test Procedure:
> > date 2013.01.28-10:00:00 (usage: date[YYYY.]MM.DD-hh:mm[:ss]) hwclock 
> > -w reset board and check system time.
> 
> Queuing this for v3.9. The testing information above is useful and should be part of the changelog. I moved it there while committing.
> 
> It will be nice to check the alarm functionality as well. Can you check that and let me know that works as well?

I tried to test RTC alarm using "rtcwake" command, however it is not working and returning following error 
"rtcwake: /dev/rtc0 not enabled for wakeup events"
This is coming because we have not registered RTC device as a wakeup source yet. 

For checking RTC alarm interrupt, I developed one simple program which opens RTC device, set alarm and exits.
Then by entering "cat /proc/interrupts" checked RTC interrupt count.

Using above test it confirms that RTC alarm functionality is working fine. 

> 
> Thanks,
> Sekhar
> 


Regards, 
Mrugesh

Re: [PATCH V2] ARM: davinci: da850: add RTC DT entries

[Sekhar Nori]

On 1/29/2013 1:05 PM, Katepallewar, Mrugesh wrote:
> On Mon, Jan 28, 2013 at 21:32:13, Nori, Sekhar wrote:
>> Hi Mrugesh,
>>
>> On 1/28/2013 1:17 PM, Mrugesh Katepallewar wrote:
>>> Add RTC DT entries in da850 dts file.
>>>
>>> Signed-off-by: Mrugesh Katepallewar <mrugesh.mk@ti.com>
>>> ---
>>> Applies on top of v3.8-rc4 of linus tree.
>>>
>>> This patch is depending on
>>> "ARM: davinci: da850: add interrupt-parent property in soc node"
>>> https://patchwork.kernel.org/patch/2044101/
>>
>>> Tested on da850-evm device.
>>>
>>> Test Procedure:
>>> date 2013.01.28-10:00:00 (usage: date[YYYY.]MM.DD-hh:mm[:ss]) hwclock 
>>> -w reset board and check system time.
>>
>> Queuing this for v3.9. The testing information above is useful and should be part of the changelog. I moved it there while committing.
>>
>> It will be nice to check the alarm functionality as well. Can you check that and let me know that works as well?
> 
> I tried to test RTC alarm using "rtcwake" command, however it is not working and returning following error 
> "rtcwake: /dev/rtc0 not enabled for wakeup events"
> This is coming because we have not registered RTC device as a wakeup source yet.

rtcwake is too much to use if the purpose is just to test the alarm
functionality.

> For checking RTC alarm interrupt, I developed one simple program which opens RTC device, set alarm and exits.
> Then by entering "cat /proc/interrupts" checked RTC interrupt count.

No need of writing your own. Simply use the one in Documentation/rtc.txt

> Using above test it confirms that RTC alarm functionality is working fine. 

Okay. Thanks for confirming.

Regards,
Sekhar