From: kishon <kishon-l0cyMroinI0@public.gmane.org>
To: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Michael Grzeschik
<m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH,RFC] usb: add devicetree helpers for determining dr_mode and phy_type
Date: Tue, 29 Jan 2013 19:40:23 +0530 [thread overview]
Message-ID: <5107D84F.80401@ti.com> (raw)
In-Reply-To: <20130129135336.GA3323-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On Tuesday 29 January 2013 07:23 PM, Wolfram Sang wrote:
>>> + err = of_property_read_string(np, "phy_type", &phy_type);
>>> + if (err < 0)
>>> + return USBPHY_INTERFACE_MODE_NA;
>>
>> Why don't we use a u32 property type for the *phy-type*? IMHO we
>> should use string property only when the property should be
>> absolutely unambiguous (e.g., compatible property should be string).
>
> If we would use u32-numbers in the compatible entry, this would also be
> unambiguous, no? 0xd00dfeed would be the at24-driver. Pretty specific.
hehe... But we don't have a corresponding *enum* representing the
drivers :-)
>
> I don't mind having readable devicetrees. And we have it for ethernet
> phys already with strings, so it would be consistent.
Ok. Fine with it then :-)
Thanks
Kishon
next prev parent reply other threads:[~2013-01-29 14:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 11:22 [PATCH,RFC] usb: add devicetree helpers for determining dr_mode and phy_type Sascha Hauer
[not found] ` <1359458548-25071-1-git-send-email-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-01-29 11:55 ` Alexander Shishkin
[not found] ` <87pq0omcfb.fsf-qxRn5AmX6ZD9BXuAQUXR0fooFf0ArEBIu+b9c/7xato@public.gmane.org>
2013-01-30 2:06 ` Peter Chen
2013-01-30 14:00 ` Sascha Hauer
[not found] ` <20130130140015.GZ1906-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-01-31 2:05 ` Peter Chen
2013-01-31 10:29 ` Sascha Hauer
[not found] ` <20130131102913.GA6937-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-02-01 1:11 ` Peter Chen
2013-02-01 6:58 ` Sascha Hauer
[not found] ` <20130201065833.GV1906-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-02-01 12:21 ` Peter Chen
2013-01-29 13:44 ` kishon
[not found] ` <5107D253.5030400-l0cyMroinI0@public.gmane.org>
2013-01-29 13:53 ` Wolfram Sang
[not found] ` <20130129135336.GA3323-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-01-29 14:10 ` kishon [this message]
[not found] ` <5107D84F.80401-l0cyMroinI0@public.gmane.org>
2013-01-29 14:33 ` Felipe Balbi
[not found] ` <20130129143302.GF2046-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-01-29 14:55 ` Wolfram Sang
[not found] ` <20130129145500.GB3323-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-01-29 15:05 ` Marc Kleine-Budde
2013-01-30 19:33 ` Matt Sealey
[not found] ` <CAKGA1bmQCSHxy=hLh9XYkt9vSzdO=vO9XGhJX1cZFBSL=jZHvw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-01-30 19:35 ` Matt Sealey
2013-01-29 17:10 ` Stephen Warren
2013-01-29 20:30 ` Sascha Hauer
[not found] ` <20130129203050.GT1906-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-01-30 5:51 ` kishon
[not found] ` <5108B4E7.4020505-l0cyMroinI0@public.gmane.org>
2013-01-30 10:11 ` Sascha Hauer
[not found] ` <20130130101102.GV1906-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-01-30 10:31 ` kishon
2013-01-29 17:11 ` [PATCH, RFC] " Stephen Warren
[not found] ` <510802C3.7090803-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-29 17:16 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5107D84F.80401@ti.com \
--to=kishon-l0cymroini0@public.gmane.org \
--cc=alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).