From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
To: Rahul Sharma <r.sh.open@gmail.com>
Cc: Rahul Sharma <rahul.sharma@samsung.com>,
linux-samsung-soc@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, kgene.kim@samsung.com,
inki.dae@samsung.com, joshi@samsung.com
Subject: Re: [PATCH 2/4] ARM: dts: add support for mixer to exynos4
Date: Tue, 29 Jan 2013 21:24:53 +0100 [thread overview]
Message-ID: <51083015.2030403@gmail.com> (raw)
In-Reply-To: <CAPdUM4P_jf0w+B22p1hmso8uhmTXs=fLdF8WrzDWL8cPyLeTCw@mail.gmail.com>
Hi,
On 01/28/2013 07:44 AM, Rahul Sharma wrote:
>>> +
>>> + mixer: mixer {
>>> + compatible = "samsung,exynos4-mixer";
>>
>>
>> I'm afraid this compatible property it too generic. Is the video mixer IP
>> really identical an all the Exynos4 series SoCs ?
>>
>
> It is same in Exynos4210, 4212 and 4412.
>
>>
>>> + reg =<0x12c10000 0x10000>,
>>> +<0x12c00000 0x10000>;
>>> + interrupts =<0 91 0>;
>>> + samsung,power-domain =<&pd_tv>;
>>> + };
>>> };
>>
>>
>> Is there documentation for these new bindings available somewhere ?
>>
>
> it is there at Documentation/devicetree/bindings/drm/exynos/mixer.txt.
> Probably I need to add details for power domain node property.
Sorry, I can't see anything for Exynos4 there, it's only for exynos5 SoCs.
I think the need for the 'samsung,power-domain' property (I guess that
should be optional) needs to be documented for completeness.
Getting back to the bindings documentation,
Documentation/devicetree/bindings/drm/exynos/ seems not exactly right
place for me, but that's a minor issue. There is also a V4L2 driver
for the HDMI and TV output devices in drivers/media/platform/s5p-tv.
So Documentation/devicetree/bindings/video or
Documentation/devicetree/bindings/media might be a better home for that
bindings documentation. These IPs are not specific to DRM at all.
--
Thanks,
Sylwester
next prev parent reply other threads:[~2013-01-29 20:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 10:39 [PATCH 0/4] 0/4] ARM: dts: add support for hdmi to exynos4412 Rahul Sharma
2013-01-25 10:39 ` [PATCH 1/4] ARM: dts: add support for hdmi to exynos4 Rahul Sharma
[not found] ` <1359110384-28402-2-git-send-email-rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-01-25 17:40 ` Thomas Abraham
2013-01-28 6:55 ` Rahul Sharma
2013-01-28 8:44 ` Tomasz Figa
2013-01-28 9:23 ` Rahul Sharma
2013-01-28 18:48 ` Tomasz Figa
2013-01-27 20:54 ` Sylwester Nawrocki
2013-01-28 6:19 ` Rahul Sharma
2013-01-29 20:42 ` Sylwester Nawrocki
2013-01-31 8:09 ` Rahul Sharma
2013-01-31 22:25 ` Kukjin Kim
2013-02-01 4:04 ` Rahul Sharma
2013-01-25 10:39 ` [PATCH 2/4] ARM: dts: add support for mixer " Rahul Sharma
2013-01-27 21:04 ` Sylwester Nawrocki
2013-01-28 6:44 ` Rahul Sharma
2013-01-28 8:38 ` Tomasz Figa
2013-01-29 20:15 ` Sylwester Nawrocki
2013-01-29 20:24 ` Sylwester Nawrocki [this message]
2013-01-31 8:33 ` Rahul Sharma
2013-01-25 10:39 ` [PATCH 3/4] ARM: dts: add support for hdmi-ddc to exynos4412-origen Rahul Sharma
2013-01-27 20:37 ` Sylwester Nawrocki
2013-01-25 10:39 ` [PATCH 4/4] ARM: dts: add support for hdmi-phy to exynos4412 Rahul Sharma
2013-01-27 20:43 ` [PATCH 0/4] 0/4] ARM: dts: add support for hdmi " Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51083015.2030403@gmail.com \
--to=sylvester.nawrocki@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=inki.dae@samsung.com \
--cc=joshi@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=r.sh.open@gmail.com \
--cc=rahul.sharma@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).