From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH 2/4] ARM: dts: add support for mixer to exynos4 Date: Tue, 29 Jan 2013 21:24:53 +0100 Message-ID: <51083015.2030403@gmail.com> References: <1359110384-28402-1-git-send-email-rahul.sharma@samsung.com> <1359110384-28402-3-git-send-email-rahul.sharma@samsung.com> <5105965F.9050402@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org To: Rahul Sharma Cc: Rahul Sharma , linux-samsung-soc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, kgene.kim@samsung.com, inki.dae@samsung.com, joshi@samsung.com List-Id: devicetree@vger.kernel.org Hi, On 01/28/2013 07:44 AM, Rahul Sharma wrote: >>> + >>> + mixer: mixer { >>> + compatible = "samsung,exynos4-mixer"; >> >> >> I'm afraid this compatible property it too generic. Is the video mixer IP >> really identical an all the Exynos4 series SoCs ? >> > > It is same in Exynos4210, 4212 and 4412. > >> >>> + reg =<0x12c10000 0x10000>, >>> +<0x12c00000 0x10000>; >>> + interrupts =<0 91 0>; >>> + samsung,power-domain =<&pd_tv>; >>> + }; >>> }; >> >> >> Is there documentation for these new bindings available somewhere ? >> > > it is there at Documentation/devicetree/bindings/drm/exynos/mixer.txt. > Probably I need to add details for power domain node property. Sorry, I can't see anything for Exynos4 there, it's only for exynos5 SoCs. I think the need for the 'samsung,power-domain' property (I guess that should be optional) needs to be documented for completeness. Getting back to the bindings documentation, Documentation/devicetree/bindings/drm/exynos/ seems not exactly right place for me, but that's a minor issue. There is also a V4L2 driver for the HDMI and TV output devices in drivers/media/platform/s5p-tv. So Documentation/devicetree/bindings/video or Documentation/devicetree/bindings/media might be a better home for that bindings documentation. These IPs are not specific to DRM at all. -- Thanks, Sylwester