From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon Subject: Re: [PATCH,RFC] usb: add devicetree helpers for determining dr_mode and phy_type Date: Wed, 30 Jan 2013 16:01:05 +0530 Message-ID: <5108F669.6060500@ti.com> References: <1359458548-25071-1-git-send-email-s.hauer@pengutronix.de> <5107D253.5030400@ti.com> <20130129203050.GT1906@pengutronix.de> <5108B4E7.4020505@ti.com> <20130130101102.GV1906@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130130101102.GV1906-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sascha Hauer Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Simon Glass , Stephen Warren , alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, Michael Grzeschik , Marc Kleine-Budde List-Id: devicetree@vger.kernel.org Hi, On Wednesday 30 January 2013 03:41 PM, Sascha Hauer wrote: > On Wed, Jan 30, 2013 at 11:21:35AM +0530, kishon wrote: >> On Wednesday 30 January 2013 02:00 AM, Sascha Hauer wrote: >>> On Tue, Jan 29, 2013 at 07:14:51PM +0530, kishon wrote: >>>> Hi, >>>> >>>> On Tuesday 29 January 2013 04:52 PM, Sascha Hauer wrote: >>>>> From: Michael Grzeschik >>>>> >>>>> This adds two little devicetree helper functions for determining the >>>>> dr_mode (host, peripheral, otg) and phy_type (utmi, ulpi,...) from >>>>> the devicetree. >>>>> >>>>> Signed-off-by: Michael Grzeschik >>>>> Signed-off-by: Marc Kleine-Budde >>>>> --- >>>>> >>>>> The properties and their values have been taken from the fsl-mph-dr driver. >>>>> This binding is also documented (though currently not used) for the tegra >>>>> ehci driver (Documentation/devicetree/bindings/usb/nvidia,tegra20-ehci.txt). >>>>> This is a first attempt to parse these bindings at a common place so that >>>>> others can make use of it. >>>>> >>>>> Basically I want to know whether this binding is recommended for new drivers >>>>> since normally the devicetree uses '-' instead of '_', and maybe there are >>>>> other problems with it. >>>>> >>>>> I need this binding for the chipidea driver. I suspect that the fsl-mph-dr >>>>> driver also really handles a chipidea core. >>>>> >>>>> Should we agree on this I would convert the fsl-mph-dr driver to use these >>>>> helpers. >>>>> >>>>> Sascha >>>>> >>>>> drivers/usb/core/Makefile | 1 + >>>>> drivers/usb/core/of.c | 76 +++++++++++++++++++++++++++++++++++++++++++++ >>>> >>>> This file should ideally go into drivers/usb/phy/. >>> >>> I originally wanted to do that, but the host/peripheral/otg property is >>> not phy specific. DO you still want to move it there? >> >> I think then you can just move of_usb_get_phy_mode() to phy/of.c. >> Then we can also move some functions defined in otg.c (specific to >> PHY and dt) to phy/of.c. > > The phy specific stuff in otg.c can't easily be moved as all functions > operate on a static list and spinlock. Also nothing in otg/otg.c is > currently of specific. Actually nothing in otg.c is specific to OTG except one function otg_state_string(). So we should ideally have all the list and spinlock stuff be moved to phy.c Some of them got added recently (like devm_usb_get_phy_by_phandle). It should be in git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next > > What about the dr_mode helper? Moving it to otg/ would mean that all *dr_mode* doesn't look like it should be in phy/ or otg/. You can keep it as is in core/of.c Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html