From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [RFC][PATCH 2/2 v3] ASoC: simple-card: add Device Tree support Date: Thu, 31 Jan 2013 10:17:20 -0700 Message-ID: <510AA720.9000904@wwwdotorg.org> References: <20130127035943.GJ4650@opensource.wolfsonmicro.com> <87vcag3hcj.wl%kuninori.morimoto.gx@renesas.com> <20130129014808.GC4748@opensource.wolfsonmicro.com> <87sj5k3f83.wl%kuninori.morimoto.gx@renesas.com> <87obg8z4u4.wl%kuninori.morimoto.gx@renesas.com> <5107FF97.1070601@wwwdotorg.org> <87halz82bm.wl%kuninori.morimoto.gx@renesas.com> <51097F0F.2030501@wwwdotorg.org> <20130131013500.GA4759@opensource.wolfsonmicro.com> <510AA551.30400@wwwdotorg.org> <20130131171158.GA15376@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130131171158.GA15376-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Mark Brown Cc: Linux-ALSA , Kuninori Morimoto , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Liam Girdwood , Simon , Kuninori Morimoto List-Id: devicetree@vger.kernel.org On 01/31/2013 10:11 AM, Mark Brown wrote: > On Thu, Jan 31, 2013 at 10:09:37AM -0700, Stephen Warren wrote: >> On 01/30/2013 06:35 PM, Mark Brown wrote: > >>> I suggested this because it seemed more legible to repeat the >>> properties by having a named structure for each property >>> rather than by repeating them all with slightly different >>> names. > >> So the only need to repeat them at all was if the two DAIs >> needed different values for some of the properties rather than >> being identical (e.g. signal polarity) or precise inversions >> (e.g. which end is master), right? > > There's more attributes that we might want to configure on the > devices than just the actual DAI link. Clocks for example. Sure, but this binding is *simple*-audio, right. If the intent is to create some more general/all-encompassing binding structure, I'd want to think about it and review it in a different way.