From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH v2 1/6] ARM: davinci: da850: fix clock lookup for mdio device Date: Sun, 3 Feb 2013 16:44:37 +0530 Message-ID: <510E469D.9020807@ti.com> References: <1359380879-26306-1-git-send-email-prabhakar.lad@ti.com> <1359380879-26306-2-git-send-email-prabhakar.lad@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1359380879-26306-2-git-send-email-prabhakar.lad-l0cyMroinI0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Prabhakar Lad Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Lad, Prabhakar" , Heiko Schocher , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 1/28/2013 7:17 PM, Prabhakar Lad wrote: > From: Lad, Prabhakar > > This patch removes the clock alias for mdio device and adds a entry > in clock lookup table, this entry can now be used by both DT and NON > DT case. > > Signed-off-by: Lad, Prabhakar > Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org > Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org > Cc: Sekhar Nori > Cc: Heiko Schocher > --- > arch/arm/mach-davinci/da850.c | 1 + > arch/arm/mach-davinci/devices-da8xx.c | 8 ++------ > 2 files changed, 3 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c > index 86056ca..f74bfb6 100644 > --- a/arch/arm/mach-davinci/da850.c > +++ b/arch/arm/mach-davinci/da850.c > @@ -402,6 +402,7 @@ static struct clk_lookup da850_clks[] = { > CLK(NULL, "arm", &arm_clk), > CLK(NULL, "rmii", &rmii_clk), > CLK("davinci_emac.1", NULL, &emac_clk), > + CLK("davinci_mdio.0", "fck", &emac_clk), > CLK("davinci-mcasp.0", NULL, &mcasp_clk), > CLK("da8xx_lcdc.0", "fck", &lcdc_clk), > CLK("davinci_mmc.0", NULL, &mmcsd0_clk), > diff --git a/arch/arm/mach-davinci/devices-da8xx.c b/arch/arm/mach-davinci/devices-da8xx.c > index 2d5502d..52faa05 100644 > --- a/arch/arm/mach-davinci/devices-da8xx.c > +++ b/arch/arm/mach-davinci/devices-da8xx.c > @@ -444,12 +444,8 @@ int __init da8xx_register_emac(void) > ret = platform_device_register(&da8xx_mdio_device); > if (ret < 0) > return ret; > - ret = platform_device_register(&da8xx_emac_device); > - if (ret < 0) > - return ret; > - ret = clk_add_alias(NULL, dev_name(&da8xx_mdio_device.dev), > - NULL, &da8xx_emac_device.dev); > - return ret; > + > + return platform_device_register(&da8xx_emac_device); You added the look-up only for DA850 which means after this patch da830 network will be broken. Did you test on DA830? Thanks, Sekhar